Update ESLint configuration #347
Conversation
|
@fredden we cannot deliver this update without magento2 codebase change as the whole magento2 codebase will need to comply with these rules for the static tests to pass. I'd try to deliver these changes one by one to keep failures to minimal |
|
@sivaschenko Thanks for the update / confirmation. How are you getting on with step 3 from magento/magento2#32343 (comment)? This pull request is step 4. I've offered several times to do / help with step 3, and am still waiting for access to the relevant repositories. Are you able to organise for me to have access so that this can be progressed? |
@sivaschenko I'm happy to open individual pull requests for these; shall I make a start on this, or do we need to wait for 'step 3' to be complete per above? |
|
@fredden yes, the other approach would be to wait for step 3. I am not able to organise additional access for you, unfortunately. |
|
Thanks @sivaschenko. What's the expected timeline for completion of step 3? |
|
@fredden the step 3 is not planned at the moment |
|
How can we therefore progress with this work? |
|
@sivaschenko Please can you provide a status update on this? Am I allowed to help update/fix your linter yet? |
fredden
force-pushed
the
eslint
branch
2 times, most recently
from
e5f94f5
to
92a21dc
Compare
The documentation for 'no-mixed-operators' states: > This rule may conflict with no-extra-parens rule. If you use both this and > no-extra-parens rule together, you need to use the nestedBinaryExpressions > option of no-extra-parens rule.
|
@magento create issue |
This has been copied from magento/magento2#32343
This fixes magento/magento2#32375
The ESLint configuration currently in use was last updated four years ago. A lot has changed in the JavaScript since then. Let's update the configuration to match today's standards.
Resolved issues: