[@mantine/core] ListItem: Span limits the full width capability #2146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By Removing the span we can now pass a div or any other JSX Element which can take the full width of the container the list is in. Eg. I can put Text on the left side and have a button floated / flexed to the right side.
glomyst
changed the title
glomyst
changed the title
|
Have you checked if that works correctly in Firefox? |
|
Thanks! |
|
This actually did more harm than good. If you see this image below, it overflows the List.Item tag. I worked around this by adding tags inside the List.Item tag. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By Removing the span we can now pass a div or any other JSX Element which can take the full width of the container the list is in.
Eg. I can put Text on the left side and have a button floated / flexed to the right side.