Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@mantine/core] Radio: fix labelWrapper styles #2661

Closed
wants to merge 2 commits into from

Conversation

dekisr
Copy link

@dekisr dekisr commented Oct 7, 2022

re #2660

@dekisr
Copy link
Author

dekisr commented Oct 7, 2022

It's also affecting the Switch:
Captura de Tela 2022-10-07 às 18 38 48

@@ -118,6 +118,8 @@ export default createStyles(

labelWrapper: {
...theme.fn.fontStyles(),
display: 'flex',
alignItems: 'flex-start',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion, it would be "center", not flex-start, it's weird I guess.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, makes sense. I just changed it to how it was before these properties were removed

@@ -178,6 +178,8 @@ export default createStyles(

labelWrapper: {
...theme.fn.fontStyles(),
display: 'flex',
alignItems: 'flex-start',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And the same there

@Phosphorus-M
Copy link

I just leave some comments it does not depend on me.

@rtivital
Copy link
Member

Fixed in #2881

@rtivital rtivital closed this Nov 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants