Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[@mantine/core] Radio: fix labelWrapper styles #2661

Closed
wants to merge 2 commits into from
Closed

[@mantine/core] Radio: fix labelWrapper styles #2661

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e756ba4
[@mantine/core] Radio: fix labelWrapper styles
dekisr Oct 7, 2022
42d4675
[@mantine/core] Switch: fix labelWrapper styles
dekisr Oct 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/mantine-core/src/Radio/Radio.styles.ts
View file
Open in desktop
Expand Up @@ -118,6 +118,8 @@ export default createStyles(

labelWrapper: {
...theme.fn.fontStyles(),
display: 'flex',
alignItems: 'flex-start',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion, it would be "center", not flex-start, it's weird I guess.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, makes sense. I just changed it to how it was before these properties were removed

fontSize: theme.fontSizes[size] || theme.fontSizes.md,
lineHeight: `${theme.fn.size({ sizes, size })}px`,
color: theme.colorScheme === 'dark' ? theme.colors.dark[0] : theme.black,
Expand Down
2 changes: 2 additions & 0 deletions src/mantine-core/src/Switch/Switch.styles.ts
View file
Open in desktop
Expand Up @@ -178,6 +178,8 @@ export default createStyles(

labelWrapper: {
...theme.fn.fontStyles(),
display: 'flex',
alignItems: 'flex-start',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And the same there

WebkitTapHighlightColor: 'transparent',
fontSize: theme.fn.size({ size, sizes: theme.fontSizes }),
fontFamily: theme.fontFamily,
Expand Down