Update npm dependencies

[albertyw]

Depends on #37

There are still a few dependencies not updated:

$ npm outdated
Package                 Current  Wanted  Latest  Location                             Depended by
mocha-jenkins-reporter    0.1.9   0.1.9   0.4.7  node_modules/mocha-jenkins-reporter  mocaccino.js
supports-color            8.1.1   8.1.1   9.2.1  node_modules/supports-color          mocaccino.js

• mocha-jenkins-reporter >0.2.0 breaks the browser "use custom reporter" test (https://github.com/albertyw/mocaccino.js/blob/master/test/mocaccino-test.js#L587). It doesn't break on node tests. I'm having a hard time debugging this.
• supports-color v9 is ESM-only which breaks with

Error [ERR_REQUIRE_ESM]: require() of ES Module /home/albertyw/mocaccino.js/node_modules/supports-color/index.js from /home/albertyw/mocaccino.js/lib/mocaccino.js not supported.
Instead change the require of index.js in /home/albertyw/mocaccino.js/lib/mocaccino.js to a dynamic import() which is available in all CommonJS modules.

[m90]

Are you planning to have this land in Mochify as well in the long run? Even if the only relevant breaking change seems to be dropping Node 10 I'm wonderig if this would mean we'd have to do major version bumps on both mocaccino and Mochify?

[mantoni]

I was under the impression that we're stuck with mocha 8 because mocha 9 cannot be browserified (whole reason for the rewrite that I'm not getting over the finish line 🤭). Did that change?

[m90]

My memories might be off here, but from what I can recall that move from Browserify to Rollup in Mocha (which you might be referring to?) happened in some version before 8 already and was covered here #35 (comment) and here mantoni/mochify.js#213 (comment) so I think Mocha 9 should work. That doesn't necessarily make it true though...

[albertyw]

This PR seems to build fine when brought into mochify.js: mantoni/mochify.js#276

@mantoni Are you referring to being stuck on an old version of browserify instead of mocha (mantoni/mochify.js#224)?

[mantoni]

It used to break, I've sent a PR to fix it, but nobody replied. mochajs/mocha#4121

This was the whole reason I went off to write a new mochify, that isn't depending on a bundler (plus some other improvements in the design). See https://github.com/mantoni/mochify.js/milestone/1

[m90]

Your PR says

I'm maintaining mochify and would like to move away from depending on the pre-bundled Mocha.

which also aligns with what I remember: it's just not possible to browserify browser-entry.js file anymore because of that missing transform. Mocaccino however currently loads the pre-bundled mocha/mocha.js here:

mocaccino.js/lib/mocaccino.js

Lines 65 to 67 in aee84ab

	var mochaPath = opts.mochaPath
	? resolve.sync('mocha.js', { paths: [opts.mochaPath] })
	: resolve.sync('mocha/mocha');

so I think Mocha 9 should work fine as long as we consume the bundled version.

---

That being said, if I can help with finishing that rewrite in some way, I am happy to help, it will be worth it nonetheless :)

[albertyw]

So should we update to mocha 9 and leave a bundled mocha.js or should we stay at mocha 8 for consistency until the rewrite finishes?

[mantoni]

I trust you with this decision. If you have time to do the work, I'll support the upgrade.

[albertyw]

I removed the mocha update from this PR. It can be added in a later PR.

[albertyw]

Now that #37 is landed, I rebased this PR and it should be ready to land, pending the mocha question.

[mantoni]

Shall I merge and release a major?

[m90]

I'm wondering if we should stick to 16 here so that it's in sync with the (blocked) Mochify: mantoni/mochify.js#224

[albertyw]

I removed the browserify update

[m90]

Thank you 🙌 if you're ready for upgrading Mocha too, let's do this.