Update mocaccino to v6 and mocha to v9 #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m90
reviewed
Dec 23, 2021
| @@ -85,7 +85,7 @@ | |||
| "devDependencies": { | |||
| "@studio/changes": "^2.0.1", | |||
| "eslint": "^7.13.0", | |||
| "mocha": "^8.4.0", | |||
| "mocha": "^9.1.0", | |||
There was a problem hiding this comment.
Not sure if this your intention in this PR, but this is the Mocha version used by the tests in this repo. Mochify itself will still be on version 8 as per the version of mocaccino that is used. Is that the idea here?
There was a problem hiding this comment.
I wanted to check if mochify.js would be compatible with mocha v9, as per mantoni/mocaccino.js#38 (comment).
There was a problem hiding this comment.
I added another commit to also update mocaccino (temporarily to my fork) to see if there would be any conflicts with mocha.
albertyw
force-pushed
the
update-mocha
branch
from
f10aa3f
to
b894dbd
Compare
albertyw
force-pushed
the
update-mocha
branch
from
b894dbd
to
0fa2bf1
Compare
mantoni
approved these changes
Dec 29, 2021
|
This is released as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulls in mocaccino v6 and mocha v9. Mocha v9 is used for internal testing of mochify.
Depends on mantoni/mocaccino.js#38 to update mocaccino versions.