Changes th width property to string type in schema #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfix-stripe
reviewed
Nov 28, 2023
package.json
Outdated
| @@ -1,7 +1,7 @@ | |||
| { | |||
| "name": "@markdoc/markdoc", | |||
| "author": "Ryan Paul", | |||
| "version": "0.3.5", | |||
| "version": "0.3.6", | |||
There was a problem hiding this comment.
We should probably release this as a new minor version right? Just in case it breaks folks' validation.
|
@mfix-stripe changed it from 0.3.6 to 0.4.0. |
mfix-stripe
approved these changes
Nov 30, 2023
Brandylee24
approved these changes
Jan 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The schema for the
thnode was written to expect a number for thewidthattribute, but when thewidthattribute is rendered literally in markup it needs to be a string. This PR changes the schema and also increments the package's version so we can push an update.Closes #471