Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes th width property to string type in schema #472

Merged
merged 2 commits into from
Nov 30, 2023
Merged

Changes th width property to string type in schema #472

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f54b87a
Changes th width property to string type in schema
rpaul-stripe Nov 28, 2023
3927624
Updates version to 0.4.0
rpaul-stripe Nov 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@markdoc/markdoc",
"author": "Ryan Paul",
"version": "0.3.5",
"version": "0.3.6",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably release this as a new minor version right? Just in case it breaks folks' validation.

"description": "A text markup language for documentation",
"main": "dist/index.js",
"module": "dist/index.mjs",
Expand Down
4 changes: 2 additions & 2 deletions spec/marktest/tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -712,7 +712,7 @@
- name: Advanced table format
code: |
{% table %}
* Test 1 - 1 {% width=20 %}
* Test 1 - 1 {% width="20%" %}
* Test 1 - 2
* Test 1 - 3
---
Expand All @@ -733,7 +733,7 @@
children:
- tag: th
attributes:
width: 20
width: 20%
children: ['Test 1 - 1 ']
- tag: th
children: [Test 1 - 2]
Expand Down
2 changes: 1 addition & 1 deletion src/schema.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ export const td: Schema = {
export const th: Schema = {
render: 'th',
attributes: {
width: { type: Number },
width: { type: String },
align: { type: String },
colspan: { type: Number, render: 'colSpan' },
rowspan: { type: Number, render: 'rowSpan' },
Expand Down