Remove JS layout adjustment and rely on CSS

[caddoo]

Description:

Fixes #21224

The JS calculation of width seemed to break layout in Safari from the admin screen.

Review

• Functional review done
• Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
• Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
• Security review done
• Wording review done
• Code review done
• Tests were added if useful/possible
• Reviewed for breaking changes
• Developer changelog updated if needed
• Documentation added if needed
• Existing documentation updated if needed

[michalkleiner]

The JS was updated in 2015 via c1f3328 with the commit message "in admin area make sure to use as much content width as possible", so I guess the purpose was to stretch out the main content area. The code was there already even before git times by the looks.

Are we possibly losing that by removing this whole file or has the UI or how it's currently done superseded for all widgets/views/whatever it may affect?

[caddoo]

The JS was updated in 2015 via c1f3328 with the commit message "in admin area make sure to use as much content width as possible", so I guess the purpose was to stretch out the main content area. The code was there already even before git times by the looks.

Are we possibly losing that by removing this whole file or has the UI or how it's currently done superseded for all widgets/views/whatever it may affect?

The CSS handles it most cases, I did add another commit add 100% width now it seems to work consistently.

[sgiehl]

Using global classes is always a bit "risky". This specific class would e.g. also apply here:

matomo/plugins/Feedback/templates/index.twig

Line 10 in 9a24d93

<div id="feedback-faq" class="admin">

It doesn't hurt in this case, as it doesn't have an effect, but might also be possible that a plugin might use that class for anything.
As it should only effect the admin content page, it might be better placed here:

matomo/plugins/CoreHome/stylesheets/coreHome.less

Lines 23 to 30 in d13d4c4

	#content.admin {
	display: inline-block;
	max-width: 1300px;
	> .row {
	margin: 0 -0.75rem;
	}
	}

[github-actions]

If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'.

[github-actions]

This PR was last updated more than one month ago, maybe it's time to close it. Please check if there is anything we still can do or close this PR. ping @matomo-org/core-reviewers

[michalkleiner]

I think if we get #21689 over the line we might be able to close this.

[github-actions]

If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'.

[github-actions]

This PR was last updated more than one month ago, maybe it's time to close it. Please check if there is anything we still can do or close this PR. ping @matomo-org/core-reviewers