Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preload fonts and images #187

Merged
merged 4 commits into from
Apr 26, 2023
Merged

Conversation

MadLittleMods
Copy link
Contributor

@MadLittleMods MadLittleMods commented Apr 26, 2023

Preload fonts and images

Part of #132

TODO

  • Make sure we don't duplicate load the fonts because the path comes to us as Inter-Regular.woff2?v=3.13 with a query parameter which counts as a different URL than what we preloaded, see Preload fonts and images #187 (comment)

@MadLittleMods MadLittleMods added the A-performance What is slow, what made it faster and more efficient? label Apr 26, 2023
@MadLittleMods MadLittleMods added the T-Enhancement New feature or request label Apr 26, 2023
MadLittleMods added a commit that referenced this pull request Apr 26, 2023
Of note:

 - Adds date headers, element-hq/hydrogen-web#938
 - Add "Copy matrix.to permalink" message action, element-hq/hydrogen-web#921
 - Removes `?v=3.13` query parameters from Inter font references in CSS, element-hq/hydrogen-web#961
    - This is what we need to solve #187 (comment)
@MadLittleMods MadLittleMods marked this pull request as ready for review April 26, 2023 21:26
@MadLittleMods MadLittleMods merged commit e20a67d into main Apr 26, 2023
6 checks passed
@MadLittleMods MadLittleMods deleted the madlittlemods/preload-fonts-and-images branch May 2, 2023 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-performance What is slow, what made it faster and more efficient? T-Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant