Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Hydrogen SDK dependency 0.26.0-scratch - 2023-04-26 #189

Merged
merged 2 commits into from
Apr 26, 2023
Merged

Update Hydrogen SDK dependency 0.26.0-scratch - 2023-04-26 #189

merged 2 commits into from
Apr 26, 2023

Conversation

MadLittleMods
Copy link
Contributor

@MadLittleMods MadLittleMods commented Apr 26, 2023 •
edited

Update with latest Hydrogen changes 0.26.0-scratch - 2023-04-26

Spawning from #187 (comment)

Of note:

Todo

  • Make release from our scratch branch -> @mlm/hydrogen-view-sdk@0.26.0-scratch 
    cd hydrogen-web
yarn build:sdk
cd target
Edit `target/package.json` to `@mlm/hydrogen-view-sdk@^0.26.0-scratch`
npm publish
  • Update the hydrogen-view-sdk dependency version in this PR (edit package.json in our project and npm install)

@MadLittleMods
Fix Hydrogen routing in archive room view
e7b3f02 
We have to `encodeURIComponent(roomId)` because Hydrogen was updated to do
this, see https://github.com/vector-im/hydrogen-web/pull/939/files
@MadLittleMods MadLittleMods added hydrogen Issues which involve https://github.com/vector-im/hydrogen-web T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. labels Apr 26, 2023
MadLittleMods
MadLittleMods commented Apr 26, 2023
View reviewed changes
shared/hydrogen-vm-render-script.js
const archiveHistory = new ArchiveHistory(`#/session/123/room/${roomData.id}`);
const archiveHistory = new ArchiveHistory(
// We just have to match what Hydrogen is doing here.
`#/session/123/room/${encodeURIComponent(roomData.id)}`
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to encodeURIComponent(roomId) because Hydrogen was updated to do this, see https://github.com/vector-im/hydrogen-web/pull/939/files

And we just want the base hash to match whatever Hydrogen is doing so we can do our own relative archive-history.js

@MadLittleMods MadLittleMods mentioned this pull request Apr 26, 2023
Merged
1 task
@MadLittleMods MadLittleMods changed the title Update with latest Hydrogen changes - 2023-04-26 Update Hydrogen SDK dependency - 2023-04-26 Apr 26, 2023
@MadLittleMods MadLittleMods changed the title Update Hydrogen SDK dependency - 2023-04-26 Update Hydrogen SDK dependency 0.26.0-scratch - 2023-04-26 Apr 26, 2023
@MadLittleMods MadLittleMods marked this pull request as ready for review April 26, 2023 21:17
@MadLittleMods MadLittleMods merged commit f0a1113 into main Apr 26, 2023
6 checks passed
@MadLittleMods MadLittleMods mentioned this pull request Apr 27, 2023
Open
@MadLittleMods MadLittleMods deleted the madlittlemods/update-hydrogen-2023-04-26 branch May 2, 2023 06:04
@MadLittleMods MadLittleMods mentioned this pull request May 30, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
hydrogen Issues which involve https://github.com/vector-im/hydrogen-web T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@MadLittleMods