Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mstyle compatibility data #17043

Merged
merged 2 commits into from Aug 27, 2022
Merged

Update mstyle compatibility data #17043

merged 2 commits into from Aug 27, 2022

Conversation

fred-wang
Copy link
Contributor

Summary

  • Update data for Chrome, based on info from mathml.global_attribute.

  • Update notes for Firefox, taken from Gecko-specific notes of
    https://developer.mozilla.org/en-US/docs/Web/MathML/Element/mstyle

  • Remove dir, displaystyle, scriptlevel since they now belong to
    mathml.global_attribute

  • Update scriptminsize/scriptsizemultiplier, removed in Firefox 103
    and not part of MathML Core.

Test results and supporting details

This was essentially copying info from #16995, https://bugzilla.mozilla.org/show_bug.cgi?id=1772697 and https://developer.mozilla.org/en-US/docs/Web/MathML/Element/mstyle

Related issues

This is needed for mdn/content#18273

@github-actions github-actions bot added the data:mathml ➗ Compat data for MathML features. https://developer.mozilla.org/docs/Web/MathML label Jul 19, 2022
@fred-wang
Copy link
Contributor Author

cc @queengooborg @teoli2003

@queengooborg queengooborg self-requested a review July 20, 2022 19:40
fred-wang added a commit to fred-wang/browser-compat-data that referenced this pull request Jul 21, 2022
The information for MathML global attributes has been added to a
separate file [1] so it does not need to be repeated for each
individual MathML element anymore. That also makes things
consistent with what HTML does. Note that the case of mstyle is
handled in [2].

[1] mdn#16995
[2] mdn#17043
queengooborg added a commit that referenced this pull request Aug 9, 2022
The information for MathML global attributes has been added to a
separate file [1] so it does not need to be repeated for each
individual MathML element anymore. That also makes things
consistent with what HTML does. Note that the case of mstyle is
handled in [2].

[1] #16995
[2] #17043

Co-authored-by: Queen Vinyl Da.i'gyu-Kazotetsu <vinyldarkscratch@gmail.com>
* Update data for Chrome, based on info from mathml.global_attribute.

* Update notes for Firefox, taken from Gecko-specific notes of
  https://developer.mozilla.org/en-US/docs/Web/MathML/Element/mstyle

* Remove dir, displaystyle, scriptlevel since they now belong to
  mathml.global_attribute

* Update scriptminsize/scriptsizemultiplier, removed in Firefox 103
  and not part of MathML Core.
@fred-wang
Copy link
Contributor Author

@queengooborg any update on the review here?

Copy link
Collaborator

@queengooborg queengooborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eventually, we should probably get those attributes separated into subfeatures, but we can worry about that later. For now, LGTM!

@queengooborg queengooborg merged commit 7ddcafb into mdn:main Aug 27, 2022
@fred-wang fred-wang deleted the mstyle branch August 27, 2022 07:16
@fred-wang
Copy link
Contributor Author

Eventually, we should probably get those attributes separated into subfeatures, but we can worry about that later. For now, LGTM!

I'm not sure I understand this? All attributes are already handled as subfeatures no? And all the ones removed here are in mathml.global_attribute?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:mathml ➗ Compat data for MathML features. https://developer.mozilla.org/docs/Web/MathML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants