Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate MathML attributes scriptmize and scriptsizemultiplier #18273

Merged
merged 1 commit into from
Jul 21, 2022

Conversation

fred-wang
Copy link
Contributor

Summary

Deprecate MathML attributes scriptmize and scriptsizemultiplier and document change in Firefox 103.

Motivation

These attributes have been removed from Firefox 103, not implemented in any other browsers and not part of MathML Core.

Supporting details

https://bugzilla.mozilla.org/show_bug.cgi?id=1772697
https://w3c.github.io/mathml-core/#style-change-mstyle

Related issues

Metadata

  • Adds a new document
  • Rewrites (or significantly expands) a document
  • [x ] Fixes a typo, bug, or other error

@fred-wang fred-wang requested a review from a team as a code owner July 12, 2022 13:27
@fred-wang fred-wang requested review from Rumyra and removed request for a team July 12, 2022 13:27
@github-actions github-actions bot added Content:MathML MathML docs Content:Other Any docs not covered by another "Content:" label labels Jul 12, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 12, 2022

Preview URLs

Flaws

None! 🎉

External URLs

URL: /en-US/docs/Mozilla/Firefox/Releases/103
Title: Firefox 103 for developers
on GitHub

No new external URLs


URL: /en-US/docs/Web/MathML/Attribute
Title: MathML attribute reference
on GitHub

No new external URLs


URL: /en-US/docs/Web/MathML/Element/mstyle
Title: <mstyle>
on GitHub

No new external URLs

(this comment was updated 2022-07-21 12:15:52.532999)

@teoli2003 teoli2003 requested review from teoli2003 and removed request for Rumyra July 12, 2022 13:43
Copy link
Member

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(More of a question)

Comment on lines 87 to 89
- Starting with Gecko 29.0 {{geckoRelease("29.0")}}, the attributes accepted on the `<mstyle>` element have been restricted to those actually used in practice: `id, class, style, href, mathcolor, mathbackground, scriptlevel, displaystyle, scriptsizemultiplier, scriptminsize, dir, mathsize, mathvariant, fontfamily, fontweight, fontstyle, fontsize, color, background`.

- Starting with Gecko 103.0 {{geckoRelease("103.0")}}, support for attributes `scriptsizemultiplier` and `scriptminsize` has been removed.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we have mdn/browser-compat-data for this?

It would be nice to add a Specifications and a Browser_compatibility page like we do for the rest of MDN.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess yes, probably.... But I guess there is a lot of of MathML data to update on mdn/browser-compat-data, this PR is just a first step to make clear these are deprecated...

(Incidentally, I don't know whether we can do "supported in XXX under a flag" or "removed in XXX since version YYY" which we will probably need)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it looks like https://github.com/mdn/browser-compat-data/blob/main/mathml/elements/mstyle.json has some data already, let's add the section

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mmh, and Specifications and a Browser_compatibility sections are already present above actually (try to show more context). These Gecko-specific notes are very long...

Copy link
Member

@teoli2003 teoli2003 Jul 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@queengooborg I think these notes (https://pr18273.content.dev.mdn.mozit.cloud/en-US/docs/Web/MathML/Element/mstyle#gecko-specific_notes ) should be in bcd. Any advice on how to format/list them?

@fred-wang We try to avoid notes in Browser compat section nowadays (we don't succeed at 100% but we did some progress…)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, browser compatibility data should definitely be placed in BCD rather than on the pages itself. There is a lot of information in these notes, some of which could be applied to existing subfeatures (scriptminsize and scriptsizemultiplier). I think that some of these should be split into multiple statements with partial_implementation in BCD, for example the first note about lack of complete implementation before Firefox 6.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the notes from MDN and open mdn/browser-compat-data#17043 for BCD.

Also remove Gecko-specific notes, moved to browser-compat-data.
@fred-wang fred-wang force-pushed the deprecate-script-attributes branch from 5d98f0c to a8d9e0b Compare July 21, 2022 12:12
Copy link
Member

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@teoli2003 teoli2003 merged commit cfeaf30 into mdn:main Jul 21, 2022
@fred-wang fred-wang deleted the deprecate-script-attributes branch July 21, 2022 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:MathML MathML docs Content:Other Any docs not covered by another "Content:" label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants