FF98 OffscreenCanvasRenderingContext2D support added behind pref #17513
Conversation
github-actions
bot
added
the
data:api 🐇
|
@queengooborg This probably needs more work to specify why it is "partial" but it is strictly accurate for now. |
|
@queengooborg Ping |
Co-authored-by: Queen Vinyl Da.i'gyu-Kazotetsu <vinyldarkscratch@gmail.com>
| { | ||
| "version_added": "preview", | ||
| "partial_implementation": true, | ||
| "notes": "See <a href='https://bugzil.la/1746750'>bug 1746750</a>." |
There was a problem hiding this comment.
(I'm trying to understand the newly introduced impl_url)
Should this use impl_url?
There was a problem hiding this comment.
This only really says "bug" or "commit" URL. Not what it should be. So probably.
But the implication is that this should be a tracking bug for the actual implementation. Would be nice to have clarification the intent.
| "notes": "See <a href='https://bugzil.la/1746750'>bug 1746750</a>." | |
| "impl_url": "https://bugzil.la/1746750" |
There was a problem hiding this comment.
Yeah, this should probably use the new impl_url property rather than a note. A note will still need to be present with the partial_implementation key, which would be a good opportunity to describe how exactly the feature is "partial implementation"!
There was a problem hiding this comment.
@queengooborg I don't think this should be partial at all. Instead we should remove the partial_implementation and indicate the support for each part of it in the appropriate methods.
I'm waiting on response from developers for what is supported: https://bugzilla.mozilla.org/show_bug.cgi?id=1746750#c18
@bsmth Have you started looking at test code that would allow us to verify which parts of the offscreencanvas have implementations? I suspect that this will mirror the canvas2D, but we don't "know"
|
This pull request has merge conflicts that must be resolved before it can be merged. |
|
#17880 was merged which sets this feature to "105". As a result, this flag data is now irrelevant and doesn't need to be added. I'm going to close this PR accordingly. |
FF98 added support for
OffscreenCanvasRenderingContext2Din https://bugzilla.mozilla.org/show_bug.cgi?id=1746750. This just makes same thing visible on preview.Other docs related to this can be tracked in mdn/content#18772