Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FF98 OffscreenCanvasRenderingContext2D support added behind pref #17513

Closed
wants to merge 3 commits into from
Closed

FF98 OffscreenCanvasRenderingContext2D support added behind pref #17513

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eb713d8
FF98 OffscreenCanvasRenderingContext2D support added behind pref
hamishwillee Aug 22, 2022
148082c
Merge branch 'main' into ff98OffscreenCanvasRenderingContext2D
hamishwillee Aug 26, 2022
6be2fc8
Update api/OffscreenCanvasRenderingContext2D.json
hamishwillee Aug 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
22 changes: 19 additions & 3 deletions api/OffscreenCanvasRenderingContext2D.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,25 @@
},
"chrome_android": "mirror",
"edge": "mirror",
"firefox": {
"version_added": false
},
"firefox": [
{
"version_added": "preview",
"partial_implementation": true,
"notes": "See <a href='https://bugzil.la/1746750'>bug 1746750</a>."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I'm trying to understand the newly introduced impl_url)
Should this use impl_url?

Copy link
Collaborator Author

@hamishwillee hamishwillee Aug 26, 2022 •
edited by queengooborg

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only really says "bug" or "commit" URL. Not what it should be. So probably.

But the implication is that this should be a tracking bug for the actual implementation. Would be nice to have clarification the intent.

Suggested change
"notes": "See <a href='https://bugzil.la/1746750'>bug 1746750</a>."
"impl_url": "https://bugzil.la/1746750"

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this should probably use the new impl_url property rather than a note. A note will still need to be present with the partial_implementation key, which would be a good opportunity to describe how exactly the feature is "partial implementation"!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@queengooborg I don't think this should be partial at all. Instead we should remove the partial_implementation and indicate the support for each part of it in the appropriate methods.

I'm waiting on response from developers for what is supported: https://bugzilla.mozilla.org/show_bug.cgi?id=1746750#c18

@bsmth Have you started looking at test code that would allow us to verify which parts of the offscreencanvas have implementations? I suspect that this will mirror the canvas2D, but we don't "know"

},
{
"version_added": "98",
"partial_implementation": true,
"notes": "See <a href='https://bugzil.la/1746750'>bug 1746750</a>.",
"flags": [
{
"type": "preference",
"name": "gfx.offscreencanvas.enabled",
"value_to_set": "true"
}
]
}
],
"firefox_android": "mirror",
"ie": {
"version_added": false
Expand Down