Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add height/width attributes to HTML source element #18081

Merged
merged 14 commits into from Nov 24, 2022

Conversation

dletorey
Copy link
Contributor

Summary

Added browser compat data for height & width attribute on

Test results and supporting details

used npm run test to run unittests locally

Related issues

@github-actions github-actions bot added the data:html 📄 Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML label Oct 25, 2022
@queengooborg queengooborg changed the title 20927 Add height/width attributes to HTML source element Oct 29, 2022
Copy link
Collaborator

@queengooborg queengooborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there, thank you for your PR and welcome to BCD! I was able to confirm Chrome support based on https://chromestatus.com/feature/5737185317748736 and Firefox support from the linked bug. Could you provide sources for where "Safari 15" had come from?

Also, we can mirror Opera Android as well:

html/elements/source.json Outdated Show resolved Hide resolved
html/elements/source.json Outdated Show resolved Hide resolved
@dletorey
Copy link
Contributor Author

Ah yes, I confirmed Safari by testing in Browserstack, I am not positive about Opera Android, I shall test and confirm when working next.
Thank you

dletorey and others added 2 commits November 1, 2022 14:47
Yes all good

Co-authored-by: Queen Vinyl Da.i'gyu-Kazotetsu <vinyldarkscratch@gmail.com>
@hamishwillee
Copy link
Collaborator

@dletorey I added the FF108 BCD stuff as suggestions - can you accept those please?

When are the remaining changes to get this in planned?

@bsmth
Copy link
Member

bsmth commented Nov 15, 2022

It looks like I don't have permissions to merge the suggestions, so this can wait for @dletorey to apply.

Also @queengooborg should we be removing the flag data here per flag guidelines?

once a feature has landed in a stable browser release, the flag data quickly becomes irrelevant and may be removed from BCD

@queengooborg
Copy link
Collaborator

Yes, we should remove the flag data per the guidelines to help consolidate the data. Firefox 108 is only one release away!

Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks 👍🏻

@hamishwillee
Copy link
Collaborator

hamishwillee commented Nov 18, 2022

EDITED: I stand by this statement, but it's not worth reverting. So for this case at least, please ignore.

Yes, we should remove the flag data per the guidelines to help consolidate the data. Firefox 108 is only one release away!

@queengooborg IMO what we should always add the flag data and use tooling to sweep through and remove the prefs when releases are made. Why?

  • You're always going to have some omissions so you need to tool anyway.
  • If this went in now, there would be 1 month where there would be no information on MDN about how to enable the preference and the release build doesn't have it. So we're basically "wrong" for a month.
  • Its easier to revert if the feature doesn't go into a release, because the information is right there. These things get reverted sometimes so it is not a theoretical problem.

This was referenced Nov 18, 2022
Co-authored-by: Queen Vinyl Da.i'gyu-Kazotetsu <vinyldarkscratch@gmail.com>
Copy link
Collaborator

@queengooborg queengooborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:html 📄 Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants