New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add height/width attributes to HTML source element #18081
Conversation
…in with the correct data
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there, thank you for your PR and welcome to BCD! I was able to confirm Chrome support based on https://chromestatus.com/feature/5737185317748736 and Firefox support from the linked bug. Could you provide sources for where "Safari 15" had come from?
Also, we can mirror Opera Android as well:
Ah yes, I confirmed Safari by testing in Browserstack, I am not positive about Opera Android, I shall test and confirm when working next. |
Yes all good Co-authored-by: Queen Vinyl Da.i'gyu-Kazotetsu <vinyldarkscratch@gmail.com>
@dletorey I added the FF108 BCD stuff as suggestions - can you accept those please? When are the remaining changes to get this in planned? |
It looks like I don't have permissions to merge the suggestions, so this can wait for @dletorey to apply. Also @queengooborg should we be removing the flag data here per flag guidelines?
|
Yes, we should remove the flag data per the guidelines to help consolidate the data. Firefox 108 is only one release away! |
Co-authored-by: Hamish Willee <hamishwillee@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good thanks 👍🏻
EDITED: I stand by this statement, but it's not worth reverting. So for this case at least, please ignore.
@queengooborg IMO what we should always add the flag data and use tooling to sweep through and remove the prefs when releases are made. Why?
|
Co-authored-by: Queen Vinyl Da.i'gyu-Kazotetsu <vinyldarkscratch@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
Summary
Added browser compat data for height & width attribute on
Test results and supporting details
used
npm run test
to run unittests locallyRelated issues