Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add in some updates to WebTransport data #18209

Merged
merged 2 commits into from Dec 18, 2022

Conversation

chrisdavidmills
Copy link
Collaborator

@chrisdavidmills chrisdavidmills commented Nov 14, 2022

Summary

This PR provides some updates to the WebTransport API data. You can see more details about my work in my research document

Review status: awaiting tech review from a Chromium SME.

Summary of this work:

  • I've added alternative name information for a few items; the web.dev WebTransport article suggests that a few names have changed since that was written. I have put Chrome 100 in for the version where it changed, but I don't know this for definite as yet. I've asked the responsible engineer to clarify.
  • I've added in a couple of new additions to Chrome that were implemented since the initial implementation — serverCertificateHashes and BYOB reader support
  • Note that a couple of interfaces — WebTransportReceiveStream and WebTransportSendStream don't seem to be implemented yet. These are basically just special versions of ReadableStream and WritableStream that inherit from them and add a getStats() method in each case. For now, it looks like Chrome uses ReadableStream and WritableStream directly. There is no point documenting features that are not supported anywhere yet, so I'm going to leave these for now.

Test results and supporting details

Related issues

@github-actions github-actions bot added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Nov 14, 2022
@chrisdavidmills chrisdavidmills marked this pull request as draft November 14, 2022 14:38
@chrisdavidmills chrisdavidmills marked this pull request as ready for review December 5, 2022 07:15
@queengooborg queengooborg merged commit 528c4e6 into mdn:main Dec 18, 2022
@chrisdavidmills chrisdavidmills deleted the WebTransport-data-updates branch December 18, 2022 18:54
@chrisdavidmills
Copy link
Collaborator Author

@queengooborg yay, thanks for all the work on these PRs!

queengooborg added a commit to queengooborg/browser-compat-data that referenced this pull request Jan 11, 2023
This PR updates and corrects version values for Chromium (Chrome, Opera, Samsung Internet, WebView Android) for the `WebTransport` API, based upon results from the [mdn-bcd-collector](https://mdn-bcd-collector.gooborg.com) project (v7.1.3).

Tests Used: https://mdn-bcd-collector.gooborg.com/tests/api/WebTransport

_Check out the [collector's guide on how to review this PR](https://github.com/GooborgStudios/mdn-bcd-collector#reviewing-bcd-changes)._

---

Note: the alternative names were removed from the data because I could not find any evidence of them in Chrome 97.  This data was added in mdn#18209 but the author mentioned the data wasn't quite definitive so I believe it's purely incorrect.
queengooborg added a commit to queengooborg/browser-compat-data that referenced this pull request Jan 11, 2023
This PR updates and corrects version values for Chromium (Chrome, Opera, Samsung Internet, WebView Android) for the `WebTransportBidirectionalStream` API, based upon results from the [mdn-bcd-collector](https://mdn-bcd-collector.gooborg.com) project (v7.1.3).

Tests Used: https://mdn-bcd-collector.gooborg.com/tests/api/WebTransportBidirectionalStream

_Check out the [collector's guide on how to review this PR](https://github.com/GooborgStudios/mdn-bcd-collector#reviewing-bcd-changes)._

---

Note: the alternative names were removed from the data because I could not find any evidence of them in Chrome 97.  This data was added in mdn#18209 but the author mentioned the data wasn't quite definitive so I believe it's purely incorrect.
@queengooborg
Copy link
Collaborator

FYI, I ran the collector and found no evidence of the prefixes in Chrome 97. I opened #18638 and #18639 to revert that part of this PR.

@chrisdavidmills
Copy link
Collaborator Author

FYI, I ran the collector and found no evidence of the prefixes in Chrome 97. I opened #18638 and #18639 to revert that part of this PR.

s/prefixes/alternative names

queengooborg added a commit that referenced this pull request Jan 17, 2023
* Update Chromium versions for WebTransport API

This PR updates and corrects version values for Chromium (Chrome, Opera, Samsung Internet, WebView Android) for the `WebTransport` API, based upon results from the [mdn-bcd-collector](https://mdn-bcd-collector.gooborg.com) project (v7.1.3).

Tests Used: https://mdn-bcd-collector.gooborg.com/tests/api/WebTransport

_Check out the [collector's guide on how to review this PR](https://github.com/GooborgStudios/mdn-bcd-collector#reviewing-bcd-changes)._

---

Note: the alternative names were removed from the data because I could not find any evidence of them in Chrome 97.  This data was added in #18209 but the author mentioned the data wasn't quite definitive so I believe it's purely incorrect.

* Update Chromium versions for WebTransportBidirectionalStream API

This PR updates and corrects version values for Chromium (Chrome, Opera, Samsung Internet, WebView Android) for the `WebTransportBidirectionalStream` API, based upon results from the [mdn-bcd-collector](https://mdn-bcd-collector.gooborg.com) project (v7.1.3).

Tests Used: https://mdn-bcd-collector.gooborg.com/tests/api/WebTransportBidirectionalStream

_Check out the [collector's guide on how to review this PR](https://github.com/GooborgStudios/mdn-bcd-collector#reviewing-bcd-changes)._

---

Note: the alternative names were removed from the data because I could not find any evidence of them in Chrome 97.  This data was added in #18209 but the author mentioned the data wasn't quite definitive so I believe it's purely incorrect.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants