New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Chromium versions for WebTransport API #18638
Conversation
This PR updates and corrects version values for Chromium (Chrome, Opera, Samsung Internet, WebView Android) for the `WebTransport` API, based upon results from the [mdn-bcd-collector](https://mdn-bcd-collector.gooborg.com) project (v7.1.3). Tests Used: https://mdn-bcd-collector.gooborg.com/tests/api/WebTransport _Check out the [collector's guide on how to review this PR](https://github.com/GooborgStudios/mdn-bcd-collector#reviewing-bcd-changes)._ --- Note: the alternative names were removed from the data because I could not find any evidence of them in Chrome 97. This data was added in mdn#18209 but the author mentioned the data wasn't quite definitive so I believe it's purely incorrect.
This PR updates and corrects version values for Chromium (Chrome, Opera, Samsung Internet, WebView Android) for the `WebTransportBidirectionalStream` API, based upon results from the [mdn-bcd-collector](https://mdn-bcd-collector.gooborg.com) project (v7.1.3). Tests Used: https://mdn-bcd-collector.gooborg.com/tests/api/WebTransportBidirectionalStream _Check out the [collector's guide on how to review this PR](https://github.com/GooborgStudios/mdn-bcd-collector#reviewing-bcd-changes)._ --- Note: the alternative names were removed from the data because I could not find any evidence of them in Chrome 97. This data was added in mdn#18209 but the author mentioned the data wasn't quite definitive so I believe it's purely incorrect.
Maybe @chrisdavidmills could review here and/or find out the definite answer. |
I (am pretty sure) I got these alternative names from https://web.dev/webtransport/; I thought it would be important to make sure we mention them because it would look weird to have MDN docs with one set of member names, and the official Google Chrome tutorial with different names. However, looking again, I can no longer see usage of I can still see mention of |
…eam/chrome' into api/WebTransport/chrome
I found that the article was modified in between the opening of your PR and this PR to where In regards to the What is interesting, though, is that in the current version of the IDL for this interface, there is an Looking deeper through the history, it appears that Chrome's IDL did originally call this interface Here's what I think happened:
|
Good analysis, thanks @queengooborg . In addition, I got some feedback from the implementer/spec author.
So upshot is, I think we can get rid of all the alternative names without any problems. In terms of version number, I think we could put everything at 97 except for:
|
Thanks for the confirmation, @chrisdavidmills! Would you say that these changes are good, then? |
Yes. |
Awesome, I'll consider that to be official approval for this PR and merge this for tomorrow's (today's) release! |
This PR updates and corrects version values for Chromium (Chrome, Opera, Samsung Internet, WebView Android) for the
WebTransport
API, based upon results from the mdn-bcd-collector project (v7.1.3).Tests Used:
https://mdn-bcd-collector.gooborg.com/tests/api/WebTransport
https://mdn-bcd-collector.gooborg.com/tests/api/WebTransportBidirectionalStream
Check out the collector's guide on how to review this PR.
Note: the alternative names were removed from the data because I could not find any evidence of them in Chrome 97. This data was added in #18209 but the author mentioned the data wasn't quite definitive.