New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add export * as ns
support data
#6394
Conversation
930b317
to
dbdae59
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR, @JLHwung! The data checks out nicely—good research.
I do have a structural change to suggest, though. I think the feature should be a direct subfeature of export
(at the same level as default
, just before the current feature). That will allow simplifying some the data as well—see the line comment for details.
Thank you again!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This ships in Firefox 80 :)
https://groups.google.com/g/mozilla.dev.platform/c/NSzWY92Ut0o
Did you mean
Also |
Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
6ee9d58
to
5054f69
Compare
Ah, my apologies. I misread the folding in my editor.
No, I meant from 12.0.0. When it comes to flags, subfeatures present a slightly different story. With APIs, as opposed to language features, it's a little more obvious: if some I understood this to be a similar situation: you can't turn on the namespace feature independent of the parent modules feature. This is an area where we could stand to improve the documentation for the schema and contributions.
Yeah, this is a bit inconsistent. I'd welcome a PR fixing that too. It doesn't have to be part of this change, though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thank you! 🎉
A checklist to help your pull request get merged faster:
Context
Babel 7.11 will detect whether
export * as ns
should be transformed according to compat-data here: babel/babel#11849Sources:
V8: https://v8.dev/blog/v8-release-72#module-namespace-exports
SM: https://bugzilla.mozilla.org/show_bug.cgi?id=1496852, https://groups.google.com/g/mozilla.dev.platform/c/NSzWY92Ut0o?pli=1
JSC: https://bugs.webkit.org/show_bug.cgi?id=214379
Environments Mapping: https://github.com/mdn/browser-compat-data/tree/master/browsers