Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix opera version on import/export #6396

Merged
merged 1 commit into from Jul 15, 2020
Merged

fix opera version on import/export #6396

merged 1 commit into from Jul 15, 2020

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Jul 14, 2020 •
edited

A checklist to help your pull request get merged faster:

  • Summarize your changes
  • Data: link to resources that verify support information (such as browser's docs, changelogs, source control, bug trackers, and tests)
  • Review the results of the linter and fix problems reported (If you need help, please ask in a comment!)
  • Link to related issues or pull requests, if any

Opera 47 is based on Chromium 60 (source), and ESModules support is merged in Chromium 61. It is very unlikely that Opera 47 will support import/export. Likewise for Opera Android 44.

I didn't test on Opera 47 due to lack of historical version installs.

Context

@babel/preset-env will align its esmodules: true targets to browser-compat-data (PR), when reviewing the compat table changes, I guess that Opera 47 may not support import/export.

@ghost ghost added the data:js 📟 Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript label Jul 14, 2020
@JLHwung JLHwung mentioned this pull request Jul 14, 2020
Merged
ddbeck
ddbeck approved these changes Jul 15, 2020
View reviewed changes
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks very likely to be correct (the original data was ported from historically unreviewed tables on MDN). Thank you, @JLHwung! 🎉

@ddbeck ddbeck merged commit aab034f into mdn:master Jul 15, 2020
@JLHwung JLHwung deleted the fix-opera-version-modules branch July 15, 2020 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddbeck ddbeck ddbeck approved these changes

Assignees
No one assigned
Labels
data:js 📟 Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JLHwung @ddbeck