Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for C4 parser #3349

Merged
merged 4 commits into from Aug 23, 2022
Merged

Conversation

dbartholomae
Copy link
Contributor

馃搼 Summary

This adds tests for the new C4 diagram type, specifically for the parser. This PR will not contain any changes to the actual production code.

It is based on the following discussion.

For now, it's a work in progress, but will always be in a mergeable state so that if a reviewer sees it, they are encouraged to review and merge right away. This way, the first tests will be available as soon as a reviewer has time to review, and units of review can be kept small.

馃搹 Design Decisions

Tests are similar to the tests for the flowchart parser.

馃搵 Tasks

Make sure you

  • 馃摉 have read the contribution guidelines
  • 馃捇 have added unit/e2e tests (if appropriate)
  • 馃敄 targeted develop branch

@knsv
Copy link
Collaborator

knsv commented Aug 23, 2022

Thanks! Without our tests we would never dare to do any releases!

@knsv knsv merged commit 2af91f5 into mermaid-js:develop Aug 23, 2022
@dbartholomae dbartholomae deleted the add_tests_for_c4_parser branch August 24, 2022 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants