Add tests for C4 system context macros #3367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbartholomae
force-pushed
the
add_tests_for_C4_system_context_macros
branch
2 times, most recently
from
ee080a6
to
f9f87d9
Compare
sidharthv96
requested changes
Aug 28, 2022
dbartholomae
force-pushed
the
add_tests_for_C4_system_context_macros
branch
from
f9f87d9
to
1a6305c
Compare
Thanks! I'll need a bit more time to cover the parser before I can start with the renderer. |
sidharthv96
approved these changes
Sep 7, 2022
Comment on lines
+34
to
+35
| // TODO: Why are link, sprite, and tags undefined instead of not appearing at all? | ||
| // Compare to Person where they don't show up. |
There was a problem hiding this comment.
I see no reason for this. In the db I see them set to null sometimes as well. A good place to us typescript features perhaps to set the types a bit more strictly.
Another reflection is that this diagram was added recently and as such is also needs some standardisation like compliance to the theming system. A diagram author writing a c4 diagram in context using a dark theme might be surprised that the c4 diagram does not follow the theme of the other diagrams.
|
@dbartholomae Thanks for this! Coverage is important for us to keep/improve the release flow. |
fuxingloh
pushed a commit
to fuxingloh/contented
that referenced
this pull request
Nov 10, 2022
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [mermaid](https://togithub.com/mermaid-js/mermaid) | [`9.1.7` -> `9.2.2`](https://renovatebot.com/diffs/npm/mermaid/9.1.7/9.2.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>mermaid-js/mermaid</summary> ### [`v9.2.2`](https://togithub.com/mermaid-js/mermaid/releases/tag/v9.2.2): 9.2.2 [Compare Source](https://togithub.com/mermaid-js/mermaid/compare/v9.2.1...v9.2.2) #### What's Changed - \[9.2] fix(mermaid): fix `mermaid.render` types by [@​aloisklink](https://togithub.com/aloisklink) in [mermaid-js/mermaid#3768 - \[9.2] fix(mermaid): default mermaid back to CommonJS by [@​aloisklink](https://togithub.com/aloisklink) in [mermaid-js/mermaid#3767 - Fix lazy loading in webpack by [@​sidharthv96](https://togithub.com/sidharthv96) in [mermaid-js/mermaid#3774 **Full Changelog**: mermaid-js/mermaid@v9.2.1...v9.2.2 ### [`v9.2.1`](https://togithub.com/mermaid-js/mermaid/releases/tag/v9.2.1): 9.2.1 [Compare Source](https://togithub.com/mermaid-js/mermaid/compare/v9.2.0...v9.2.1) #### What's Changed - \~~fix [#​3757](https://togithub.com/mermaid-js/mermaid/issues/3757) : Remove dynamic imports for lazy load causing issues for webpack~~ - chore: Update bug report template by [@​gibson042](https://togithub.com/gibson042) in [mermaid-js/mermaid#3727 - Use issue templates and add diagram, theme and syntax proposal issue forms by [@​Andre601](https://togithub.com/Andre601) in [mermaid-js/mermaid#2739 #### New Contributors - [@​Andre601](https://togithub.com/Andre601) made their first contribution in [mermaid-js/mermaid#2739 **Full Changelog**: mermaid-js/mermaid@v9.2.0...v9.2.1 ### [`v9.2.0`](https://togithub.com/mermaid-js/mermaid/releases/tag/v9.2.0): 9.2.0 [Compare Source](https://togithub.com/mermaid-js/mermaid/compare/v9.1.7...v9.2.0) #### What's Changed ##### Features - Mindmaps by [@​knsv](https://togithub.com/knsv) in [mermaid-js/mermaid#3410 - Introducing TypeScript by [@​sidharthv96](https://togithub.com/sidharthv96) in [mermaid-js/mermaid#3336 - Auto transform `mermaid-example` in docs. by [@​sidharthv96](https://togithub.com/sidharthv96) in [mermaid-js/mermaid#3401 - Creating detectors and moving out diagram specific code from the diag… by [@​knsv](https://togithub.com/knsv) in [mermaid-js/mermaid#3436 - feat(git): cherry-pick keyword supports tag attribute by [@​elliot-nelson](https://togithub.com/elliot-nelson) in [mermaid-js/mermaid#3479 - Mindmaps replacing rendering algoritm with cose-bilkent by [@​knsv](https://togithub.com/knsv) in [mermaid-js/mermaid#3559 - 3561 theme color scales by [@​knsv](https://togithub.com/knsv) in [mermaid-js/mermaid#3562 - ESBuild by [@​sidharthv96](https://togithub.com/sidharthv96) in [mermaid-js/mermaid#3386 - (Beta) Lazy load import by [@​knsv](https://togithub.com/knsv) in [mermaid-js/mermaid#3592, [mermaid-js/mermaid#3598 - 3061 making a monorepo by [@​knsv](https://togithub.com/knsv) in [mermaid-js/mermaid#3531 ##### Fixes - Feature decimal duration in second for gantt diagram by [@​vallsv](https://togithub.com/vallsv) in [mermaid-js/mermaid#3360 - fix: fix passing a single Node to mermaid.init() by [@​aloisklink](https://togithub.com/aloisklink) in [mermaid-js/mermaid#3396 - fix [#​3407](https://togithub.com/mermaid-js/mermaid/issues/3407) Replace `div` with `pre` and format by [@​sidharthv96](https://togithub.com/sidharthv96) in [mermaid-js/mermaid#3408 - fix(git): support numeric branch names by [@​aloisklink](https://togithub.com/aloisklink) in [mermaid-js/mermaid#3392 - Add tests for C4 system context macros by [@​dbartholomae](https://togithub.com/dbartholomae) in [mermaid-js/mermaid#3367 - Add nested test for parseGenericTypes by [@​sidharthv96](https://togithub.com/sidharthv96) in [mermaid-js/mermaid#3354 - Fix memoize by [@​sidharthv96](https://togithub.com/sidharthv96) in [mermaid-js/mermaid#3434 - fix(git): support single character branch names by [@​aloisklink](https://togithub.com/aloisklink) in [mermaid-js/mermaid#3464 - Replace GoogleAnalytics with Plausible by [@​sidharthv96](https://togithub.com/sidharthv96) in [mermaid-js/mermaid#3466 - Fix for issues in errorhandling and class diagrams after refactoring by [@​knsv](https://togithub.com/knsv) in [mermaid-js/mermaid#3470 - 3409 Fix for truncated tags in GitGraph by [@​ashishjain0512](https://togithub.com/ashishjain0512) in [mermaid-js/mermaid#3454 - Fix broken cherry-pick parsing in gitgraph by [@​aloisklink](https://togithub.com/aloisklink) in [mermaid-js/mermaid#3480 - Fix CI `docs:lint` by [@​sidharthv96](https://togithub.com/sidharthv96) in [mermaid-js/mermaid#3493 - Fix user-journey leaking css by [@​lishid](https://togithub.com/lishid) in [mermaid-js/mermaid#3510 - \[sequenceDiagrams] Support dashes in participant names by [@​ashleybartlett](https://togithub.com/ashleybartlett) in [mermaid-js/mermaid#3524 - fix: ER dark theme attribute colors by [@​weedySeaDragon](https://togithub.com/weedySeaDragon) in [mermaid-js/mermaid#3512 - feat: ER diagram: allow other chars in a quoted entity name by [@​weedySeaDragon](https://togithub.com/weedySeaDragon) in [mermaid-js/mermaid#3516 - Arrow tip aligned to edge of box by [@​pbrolin47](https://togithub.com/pbrolin47) in [mermaid-js/mermaid#3533 - Fixed labelText undefined behavior by [@​AndrewL-64](https://togithub.com/AndrewL-64) in [mermaid-js/mermaid#3544 - Fix failing vitest unit tests by [@​aloisklink](https://togithub.com/aloisklink) in [mermaid-js/mermaid#3587 - fix: Import diagram by [@​sidharthv96](https://togithub.com/sidharthv96) in [mermaid-js/mermaid#3589 - Fix file name during "pnpm run dev" script by [@​vallsv](https://togithub.com/vallsv) in [mermaid-js/mermaid#3608 - fix Detect diagram fallback by [@​sidharthv96](https://togithub.com/sidharthv96) in [mermaid-js/mermaid#3591 - fix: Dirty fix for sync render. by [@​sidharthv96](https://togithub.com/sidharthv96) in [mermaid-js/mermaid#3633 - fix: Converts mindmapDB to TS by [@​sidharthv96](https://togithub.com/sidharthv96) in [mermaid-js/mermaid#3683 - Support `lazyLoadedDiagrams` when calling `initThrowsErrors` by [@​aloisklink](https://togithub.com/aloisklink) in [mermaid-js/mermaid#3702 - \[9.2.0] Support `lazyLoadedDiagrams` when calling `initThrowsErrorsAsync` by [@​aloisklink](https://togithub.com/aloisklink) in [mermaid-js/mermaid#3731 ##### Chores - build: run `build:prod` on `yarn prepare` by [@​aloisklink](https://togithub.com/aloisklink) in [mermaid-js/mermaid#3404 - chore(deps-dev): bump [@​types/dompurify](https://togithub.com/types/dompurify) from 2.3.3 to 2.3.4 by [@​dependabot](https://togithub.com/dependabot) in [mermaid-js/mermaid#3414 - chore(deps-dev): bump jest-environment-jsdom from 29.0.1 to 29.0.2 by [@​dependabot](https://togithub.com/dependabot) in [mermaid-js/mermaid#3413 - chore(deps-dev): bump typescript from 4.7.4 to 4.8.2 by [@​dependabot](https://togithub.com/dependabot) in [mermaid-js/mermaid#3411 - chore(deps-dev): bump babel-jest from 29.0.1 to 29.0.2 by [@​dependabot](https://togithub.com/dependabot) in [mermaid-js/mermaid#3412 - chore: fix JSDOC [@​param](https://togithub.com/param), [@​returns](https://togithub.com/returns) lint errors by [@​weedySeaDragon](https://togithub.com/weedySeaDragon) in [mermaid-js/mermaid#3422 - style: forbid using `console` in mermaid src code by [@​aloisklink](https://togithub.com/aloisklink) in [mermaid-js/mermaid#3405 - Introduce stricter typescript linting by [@​sidharthv96](https://togithub.com/sidharthv96) in [mermaid-js/mermaid#3393 - Esbuild: backwards-compatible `mermaid.core.mjs` by [@​aloisklink](https://togithub.com/aloisklink) in [mermaid-js/mermaid#3437 - fix(git): support unusual prefixes in branch name by [@​aloisklink](https://togithub.com/aloisklink) in [mermaid-js/mermaid#3438 - Re-enable coverage upload to coveralls by [@​aloisklink](https://togithub.com/aloisklink) in [mermaid-js/mermaid#3431 - chore(deps): bump actions/checkout from 2 to 3 by [@​dependabot](https://togithub.com/dependabot) in [mermaid-js/mermaid#3449 - chore(deps-dev): bump typescript from 4.8.2 to 4.8.3 by [@​dependabot](https://togithub.com/dependabot) in [mermaid-js/mermaid#3446 - chore(deps-dev): bump eslint from 8.23.0 to 8.23.1 by [@​dependabot](https://togithub.com/dependabot) in [mermaid-js/mermaid#3440 - chore(deps-dev): bump babel-jest from 29.0.2 to 29.0.3 by [@​dependabot](https://togithub.com/dependabot) in [mermaid-js/mermaid#3448 - chore(deps-dev): bump jest-environment-jsdom from 29.0.2 to 29.0.3 by [@​dependabot](https://togithub.com/dependabot) in [mermaid-js/mermaid#3441 - chore(deps-dev): bump [@​babel/core](https://togithub.com/babel/core) from 7.18.13 to 7.19.0 by [@​dependabot](https://togithub.com/dependabot) in [mermaid-js/mermaid#3447 - chore(deps-dev): bump [@​typescript-eslint/parser](https://togithub.com/typescript-eslint/parser) from 5.36.1 to 5.37.0 by [@​dependabot](https://togithub.com/dependabot) in [mermaid-js/mermaid#3451 - chore(deps-dev): bump [@​babel/preset-env](https://togithub.com/babel/preset-env) from 7.18.10 to 7.19.0 by [@​dependabot](https://togithub.com/dependabot) in [mermaid-js/mermaid#3442 - chore(deps-dev): bump concurrently from 7.3.0 to 7.4.0 by [@​dependabot](https://togithub.com/dependabot) in [mermaid-js/mermaid#3445 - chore(deps-dev): bump [@​typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/eslint-plugin) from 5.36.1 to 5.37.0 by [@​dependabot](https://togithub.com/dependabot) in [mermaid-js/mermaid#3457 - chore(deps-dev): bump eslint-plugin-jest from 27.0.1 to 27.0.4 by [@​dependabot](https://togithub.com/dependabot) in [mermaid-js/mermaid#3458 - Cleanup & fix eslint warnings by [@​sidharthv96](https://togithub.com/sidharthv96) in [mermaid-js/mermaid#3453 - chore(deps-dev): bump webpack-dev-server from 4.10.1 to 4.11.0 by [@​dependabot](https://togithub.com/dependabot) in [mermaid-js/mermaid#3450 - chore(deps): bump stylis from 4.1.1 to 4.1.2 by [@​dependabot](https://togithub.com/dependabot) in [mermaid-js/mermaid#3439 - chore(deps): bump dompurify from 2.3.10 to 2.4.0 by [@​dependabot](https://togithub.com/dependabot) in [mermaid-js/mermaid#3444 - chore(deps-dev): bump [@​types/lodash](https://togithub.com/types/lodash) from 4.14.184 to 4.14.185 by [@​dependabot](https://togithub.com/dependabot) in [mermaid-js/mermaid#3489 - chore(deps-dev): bump esbuild from 0.15.6 to 0.15.8 by [@​dependabot](https://togithub.com/dependabot) in [mermaid-js/mermaid#3490 - chore(deps-dev): bump eslint from 8.23.1 to 8.24.0 by [@​dependabot](https://togithub.com/dependabot) in [mermaid-js/mermaid#3521 - chore(deps-dev): bump [@​types/prettier](https://togithub.com/types/prettier) from 2.7.0 to 2.7.1 by [@​dependabot](https://togithub.com/dependabot) in [mermaid-js/mermaid#3520 - chore: fix demo chart pages by [@​weedySeaDragon](https://togithub.com/weedySeaDragon) in [mermaid-js/mermaid#3523 - Vitest by [@​sidharthv96](https://togithub.com/sidharthv96) in [mermaid-js/mermaid#3427 - Build mermaid using Vite by [@​sidharthv96](https://togithub.com/sidharthv96) in [mermaid-js/mermaid#3503 - Add "Debug Current Test File" configuration for VSCode by [@​pje](https://togithub.com/pje) in [mermaid-js/mermaid#3509 - \[DevOps] Parallel E2E by [@​sidharthv96](https://togithub.com/sidharthv96) in [mermaid-js/mermaid#3498 - chore(deps-dev): update lint-staged requirement from ^13.0.0 to ^13.0.3 by [@​dependabot](https://togithub.com/dependabot) in [mermaid-js/mermaid#3551 - chore(deps-dev): update start-server-and-test requirement from ^1.12.6 to ^1.14.0 by [@​dependabot](https://togithub.com/dependabot) in [mermaid-js/mermaid#3553 - chore(deps-dev): update jsdom requirement from ^20.0.0 to ^20.0.1 by [@​dependabot](https://togithub.com/dependabot) in [mermaid-js/mermaid#3552 - chore(deps-dev): update [@​types/express](https://togithub.com/types/express) requirement from ^4.17.13 to ^4.17.14 by [@​dependabot](https://togithub.com/dependabot) in [mermaid-js/mermaid#3555 - chore(deps-dev): update [@​types/lodash](https://togithub.com/types/lodash) requirement from ^4.14.185 to ^4.14.186 by [@​dependabot](https://togithub.com/dependabot) in [mermaid-js/mermaid#3556 - chore(deps-dev): update vitest requirement from ^0.23.1 to ^0.23.4 by [@​dependabot](https://togithub.com/dependabot) in [mermaid-js/mermaid#3557 - chore(deps-dev): update husky requirement from ^8.0.0 to ^8.0.1 by [@​dependabot](https://togithub.com/dependabot) in [mermaid-js/mermaid#3558 - chore(deps-dev): update [@​typescript-eslint/parser](https://togithub.com/typescript-eslint/parser) requirement from ^5.37.0 to ^5.39.0 by [@​dependabot](https://togithub.com/dependabot) in [mermaid-js/mermaid#3564 - chore(deps-dev): update [@​typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/eslint-plugin) requirement from ^5.37.0 to ^5.39.0 by [@​dependabot](https://togithub.com/dependabot) in [mermaid-js/mermaid#3565 - chore(deps): update [@​types/node](https://togithub.com/types/node) requirement from ^18.7.21 to ^18.8.1 by [@​dependabot](https://togithub.com/dependabot) in [mermaid-js/mermaid#3566 - chore(deps-dev): update [@​vitest/coverage-c8](https://togithub.com/vitest/coverage-c8) requirement from ^0.23.2 to ^0.23.4 by [@​dependabot](https://togithub.com/dependabot) in [mermaid-js/mermaid#3567 - chore(deps-dev): update esbuild requirement from ^0.15.8 to ^0.15.10 by [@​dependabot](https://togithub.com/dependabot) in [mermaid-js/mermaid#3569 - chore(deps-dev): update typescript requirement from ^4.8.3 to ^4.8.4 by [@​dependabot](https://togithub.com/dependabot) in [mermaid-js/mermaid#3573 - chore(deps-dev): update [@​applitools/eyes-cypress](https://togithub.com/applitools/eyes-cypress) requirement from ^3.25.7 to ^3.27.1 by [@​dependabot](https://togithub.com/dependabot) in [mermaid-js/mermaid#3568 - chore(deps-dev): update vite requirement from ^3.0.9 to ^3.1.4 by [@​dependabot](https://togithub.com/dependabot) in [mermaid-js/mermaid#3570 - chore(deps-dev): update eslint-plugin-jest requirement from ^27.0.4 to ^27.1.0 by [@​dependabot](https://togithub.com/dependabot) in [mermaid-js/mermaid#3571 - chore(deps-dev): update [@​commitlint/config-conventional](https://togithub.com/commitlint/config-conventional) requirement from ^17.0.0 to ^17.1.0 by [@​dependabot](https://togithub.com/dependabot) in [mermaid-js/mermaid#3572 - Fix `docs:build` and `docs:verify` scripts by [@​aloisklink](https://togithub.com/aloisklink) in [mermaid-js/mermaid#3534 - Fix husky `pre-commit` rules by [@​aloisklink](https://togithub.com/aloisklink) in [mermaid-js/mermaid#3536 - Fix typos in README.md by [@​elv-nate](https://togithub.com/elv-nate) in [mermaid-js/mermaid#3538 - fix(tests): E2E by [@​sidharthv96](https://togithub.com/sidharthv96) in [mermaid-js/mermaid#3574 - fix: pnpm clean in windows by [@​arpansaha13](https://togithub.com/arpansaha13) in [mermaid-js/mermaid#3595 - Update Cypress to v10 and fix E2E errors by [@​aloisklink](https://togithub.com/aloisklink) in [mermaid-js/mermaid#3459 - ci(e2e-applitols): add applitools CI action by [@​aloisklink](https://togithub.com/aloisklink) in [mermaid-js/mermaid#3483 - Remove webpack & babel by [@​sidharthv96](https://togithub.com/sidharthv96) in [mermaid-js/mermaid#3452 - Add vitepress plugin by [@​emersonbottero](https://togithub.com/emersonbottero) in [mermaid-js/mermaid#3476 - ci(e2e): fix e2e action when running from fork by [@​aloisklink](https://togithub.com/aloisklink) in [mermaid-js/mermaid#3519 - chore(deps-dev): update [@​vitest/ui](https://togithub.com/vitest/ui) requirement from ^0.23.2 to ^0.23.4 by [@​dependabot](https://togithub.com/dependabot) in [mermaid-js/mermaid#3549 - chore: Update demo diagrams for monorepo by [@​weedySeaDragon](https://togithub.com/weedySeaDragon) in [mermaid-js/mermaid#3545 - Sync `docs/` with `packages/mermaid/src/docs` by [@​aloisklink](https://togithub.com/aloisklink) in [mermaid-js/mermaid#3586 - chore: Add volta by [@​sidharthv96](https://togithub.com/sidharthv96) in [mermaid-js/mermaid#3628 - chore: Node 18 by [@​sidharthv96](https://togithub.com/sidharthv96) in [mermaid-js/mermaid#3630 - Configure Renovate by [@​renovate](https://togithub.com/renovate) in [mermaid-js/mermaid#3627 ##### Docs - Added mermerd to integrations documentation by [@​KarnerTh](https://togithub.com/KarnerTh) in [mermaid-js/mermaid#3399 - Fix typo in documentation by [@​dbartholomae](https://togithub.com/dbartholomae) in [mermaid-js/mermaid#3403 - Update duplicate copy pasted directive description by [@​mrmanc](https://togithub.com/mrmanc) in [mermaid-js/mermaid#3415 - Docs/bug 3417 by [@​weedySeaDragon](https://togithub.com/weedySeaDragon) in [mermaid-js/mermaid#3419 - Docs: add '..auto generated..' to .html documentation files by [@​weedySeaDragon](https://togithub.com/weedySeaDragon) in [mermaid-js/mermaid#3420 - Mention obsidian has native support for mermaid by [@​IanLee1521](https://togithub.com/IanLee1521) in [mermaid-js/mermaid#3513 - docs: replace `yarn` with `pnpm` in dev guide by [@​aloisklink](https://togithub.com/aloisklink) in [mermaid-js/mermaid#3535 - Corrected theme variables reference table layout by [@​marcastel](https://togithub.com/marcastel) in [mermaid-js/mermaid#3541 - Working New Documentation Vitepress by [@​emersonbottero](https://togithub.com/emersonbottero) in [mermaid-js/mermaid#3515 - CODE_OF_CONDUCT Uploaded by [@​swoyam2609](https://togithub.com/swoyam2609) in [mermaid-js/mermaid#3578 - Automated docs spell-checking via GitHub Actions (and address all reported issues) by [@​SeanKilleen](https://togithub.com/SeanKilleen) in [mermaid-js/mermaid#3600 - docs:Improved keywords in index.html by [@​aryandeelwal](https://togithub.com/aryandeelwal) in [mermaid-js/mermaid#3579 - Contribution.md updates by [@​Aniket1026](https://togithub.com/Aniket1026) in [mermaid-js/mermaid#3614 - docs: Add mermaid version to script URL by [@​sidharthv96](https://togithub.com/sidharthv96) in [mermaid-js/mermaid#3596 #### New Contributors - [@​KarnerTh](https://togithub.com/KarnerTh) made their first contribution in [mermaid-js/mermaid#3399 - [@​mrmanc](https://togithub.com/mrmanc) made their first contribution in [mermaid-js/mermaid#3415 - [@​elliot-nelson](https://togithub.com/elliot-nelson) made their first contribution in [mermaid-js/mermaid#3479 - [@​emersonbottero](https://togithub.com/emersonbottero) made their first contribution in [mermaid-js/mermaid#3476 - [@​pje](https://togithub.com/pje) made their first contribution in [mermaid-js/mermaid#3509 - [@​IanLee1521](https://togithub.com/IanLee1521) made their first contribution in [mermaid-js/mermaid#3513 - [@​ashleybartlett](https://togithub.com/ashleybartlett) made their first contribution in [mermaid-js/mermaid#3524 - [@​pbrolin47](https://togithub.com/pbrolin47) made their first contribution in [mermaid-js/mermaid#3533 - [@​elv-nate](https://togithub.com/elv-nate) made their first contribution in [mermaid-js/mermaid#3538 - [@​marcastel](https://togithub.com/marcastel) made their first contribution in [mermaid-js/mermaid#3541 - [@​AndrewL-64](https://togithub.com/AndrewL-64) made their first contribution in [mermaid-js/mermaid#3544 - [@​swoyam2609](https://togithub.com/swoyam2609) made their first contribution in [mermaid-js/mermaid#3578 - [@​SeanKilleen](https://togithub.com/SeanKilleen) made their first contribution in [mermaid-js/mermaid#3600 - [@​aryandeelwal](https://togithub.com/aryandeelwal) made their first contribution in [mermaid-js/mermaid#3579 - [@​Aniket1026](https://togithub.com/Aniket1026) made their first contribution in [mermaid-js/mermaid#3614 **Full Changelog**: mermaid-js/mermaid@v9.1.7...v9.2.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [x] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/BirthdayResearch/contented). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMi4wIiwidXBkYXRlZEluVmVyIjoiMzQuMTkuMCJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Summary
This PR only adds tests without any changes to production code, plus a small documentation typo and style fix. It adds tests for the following C4 macros:
There are also some TODO comments in the test, where the tests test for the current behavior of the C4 parser, but the current behavior might be unwanted.
This is a continuation of #3349 and it is based on this discussion.
📏 Design Decisions
Tests are similar to the tests for the flowchart parser.
📋 Tasks
Make sure you
developbranch