fix: Add support for ~test Array~string~ back in Class
#4805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #4805 +/- ##
============================================
+ Coverage 45.34% 75.26% +29.91%
============================================
Files 53 146 +93
Lines 6669 14504 +7835
Branches 32 614 +582
============================================
+ Hits 3024 10916 +7892
+ Misses 3644 3462 -182
- Partials 1 126 +125
Flags with carried forward coverage won't be shown. Click here to find out more.
|
sidharthv96
changed the base branch from
UpdateClassMemberHandling
to
develop
* develop: chore: Align with convention chore(deps): update all patch dependencies chore(deps): update all minor dependencies
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
I think the PR title is misleading. Originally, I thought we're adding |
sidharthv96
changed the title
~test Array~string~~test Array~string~ back
aloisklink
reviewed
Sep 3, 2023
There was a problem hiding this comment.
It's awesome to fix a breaking change, but I'm struggling to see what the breaking change this PR fixes actually is.
What is ~test Array~string~? Can you give an example of a Mermaid diagram that has it (maybe also showing a screenshot, if the diagram only worked in an very old version of Mermaid)?
It would also be helpful if you could point to when support for ~test Array~string~ was broken (ideally to a specific commit or PR).
|
@aloisklink this PR was actually targeted at #4534 The test case was removed in that PR. Context: #4534 (comment) |
sidharthv96
changed the title
~test Array~string~ back~test Array~string~ back in Class
sidharthv96
added
Type: Bug / Error
knsv
approved these changes
Sep 5, 2023
aloisklink
approved these changes
Sep 6, 2023
There was a problem hiding this comment.
@aloisklink this PR was actually targeted at #4534
The test case was removed in that PR.
Context: #4534 (comment)
Ahh, awesome! 👍 Great catch on getting it fixed while it was still in the develop branch.
Btw, is it worth labeling this PR with Skip changelog? Since this bug has never been released to users (it's just on the develop branch), there's less of a need to put it in the Release notes (maybe current users of ~test Array~string~ might get confused if they see this PR in the release notes).
|
Im not sure where my comment went - but this was by design. any leading ~ characters are stripped before the string is even sent to this method |
fuxingloh
pushed a commit
to fuxingloh/contented
that referenced
this pull request
Oct 3, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [mermaid](https://togithub.com/mermaid-js/mermaid) | [`10.4.0` -> `10.5.0`](https://renovatebot.com/diffs/npm/mermaid/10.4.0/10.5.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>mermaid-js/mermaid (mermaid)</summary> ### [`v10.5.0`](https://togithub.com/mermaid-js/mermaid/releases/tag/v10.5.0): 10.5.0 [Compare Source](https://togithub.com/mermaid-js/mermaid/compare/v10.4.0...v10.5.0) #### What's Changed ##### Features - feat(er): add entity name alias by [@​tomperr](https://togithub.com/tomperr) in [mermaid-js/mermaid#4758 ##### Bugfixes - Fix Twitter fontawesome class in flowchart.md by [@​GingerNinjaNicko](https://togithub.com/GingerNinjaNicko) in [mermaid-js/mermaid#4723 - fix(pie): align slices and legend orders by [@​Yokozuna59](https://togithub.com/Yokozuna59) in [mermaid-js/mermaid#4774 - Update class member handling by [@​jgreywolf](https://togithub.com/jgreywolf) in [mermaid-js/mermaid#4534 - fix(er): allow underscore as leading char by [@​tomperr](https://togithub.com/tomperr) in [mermaid-js/mermaid#4776 - Align arrows on sequence diagram by [@​sidharthv96](https://togithub.com/sidharthv96) in [mermaid-js/mermaid#4804 - fix: Allow hollow markers on edges by [@​sidharthv96](https://togithub.com/sidharthv96) in [mermaid-js/mermaid#4788 - fix: Fix for vulnerability making it possible to add javascript in class names by [@​knsv](https://togithub.com/knsv) ##### Documentation - Docs/2910 Remove n00b and fix some docs by [@​nirname](https://togithub.com/nirname) in [mermaid-js/mermaid#4767 - fix: typos by [@​omahs](https://togithub.com/omahs) in [mermaid-js/mermaid#4801 - "CSS" instead of "css" in flowchart.md by [@​jakeboone02](https://togithub.com/jakeboone02) in [mermaid-js/mermaid#4797 - fix(docs): Correct repeated text in flowchart.md by [@​andriy-koz](https://togithub.com/andriy-koz) in [mermaid-js/mermaid#4810 - Update link to Discourse theme component by [@​gschlager](https://togithub.com/gschlager) in [mermaid-js/mermaid#4811 - New Mermaid Live Editor for Confluence Cloud by [@​zhifeiyue](https://togithub.com/zhifeiyue) in [mermaid-js/mermaid#4814 - Update classDiagram.md by [@​jgreywolf](https://togithub.com/jgreywolf) in [mermaid-js/mermaid#4781 - Support member definition to initialize class by [@​sidharthv96](https://togithub.com/sidharthv96) in [mermaid-js/mermaid#4786 - fix: Add support for `~test Array~string~` back in Class by [@​sidharthv96](https://togithub.com/sidharthv96) in [mermaid-js/mermaid#4805 - Added support for millisecond and second to gantt tickInterval by [@​vertxxyz](https://togithub.com/vertxxyz) in [mermaid-js/mermaid#4778 - Add directive support to all diagrams by preprocessing by [@​sidharthv96](https://togithub.com/sidharthv96) in [mermaid-js/mermaid#4759 - Update README.md by [@​jgreywolf](https://togithub.com/jgreywolf) in [mermaid-js/mermaid#4780 ##### Chores - chore(deps): update all minor dependencies (minor) by [@​renovate](https://togithub.com/renovate) in [mermaid-js/mermaid#4783 - chore(deps): update all patch dependencies (patch) by [@​renovate](https://togithub.com/renovate) in [mermaid-js/mermaid#4782 - chore(deps): update all patch dependencies (patch) by [@​renovate](https://togithub.com/renovate) in [mermaid-js/mermaid#4809 - chore: move `commonDb` into `diagrams/common/commonDb` by [@​Yokozuna59](https://togithub.com/Yokozuna59) in [mermaid-js/mermaid#4802 - Use utf8 encoding in Jupyter example by [@​jonashaag](https://togithub.com/jonashaag) in [mermaid-js/mermaid#4701 - Update flowchart.md by [@​Ogglas](https://togithub.com/Ogglas) in [mermaid-js/mermaid#4792 - Update flowchart.md by [@​dsblank](https://togithub.com/dsblank) in [mermaid-js/mermaid#4798 - Refactor `cypress/helpers/util.ts` by [@​RohanHandore](https://togithub.com/RohanHandore) in [mermaid-js/mermaid#4340 - refactor: Fix typings in utils.ts by [@​sidharthv96](https://togithub.com/sidharthv96) in [mermaid-js/mermaid#4826 - Support ClassDefs in external diagrams by [@​sidharthv96](https://togithub.com/sidharthv96) in [mermaid-js/mermaid#4819 - Fix: flowchartElk Arrow overlap by [@​sidharthv96](https://togithub.com/sidharthv96) in [mermaid-js/mermaid#4830 - Give markers unique id's per graph by [@​chadfawcett](https://togithub.com/chadfawcett) in [mermaid-js/mermaid#4825 #### New Contributors - [@​GingerNinjaNicko](https://togithub.com/GingerNinjaNicko) made their first contribution in [mermaid-js/mermaid#4723 - [@​omahs](https://togithub.com/omahs) made their first contribution in [mermaid-js/mermaid#4801 - [@​jakeboone02](https://togithub.com/jakeboone02) made their first contribution in [mermaid-js/mermaid#4797 - [@​andriy-koz](https://togithub.com/andriy-koz) made their first contribution in [mermaid-js/mermaid#4810 - [@​gschlager](https://togithub.com/gschlager) made their first contribution in [mermaid-js/mermaid#4811 - [@​zhifeiyue](https://togithub.com/zhifeiyue) made their first contribution in [mermaid-js/mermaid#4814 - [@​vertxxyz](https://togithub.com/vertxxyz) made their first contribution in [mermaid-js/mermaid#4778 - [@​jonashaag](https://togithub.com/jonashaag) made their first contribution in [mermaid-js/mermaid#4701 - [@​Ogglas](https://togithub.com/Ogglas) made their first contribution in [mermaid-js/mermaid#4792 - [@​dsblank](https://togithub.com/dsblank) made their first contribution in [mermaid-js/mermaid#4798 - [@​RohanHandore](https://togithub.com/RohanHandore) made their first contribution in [mermaid-js/mermaid#4340 - [@​chadfawcett](https://togithub.com/chadfawcett) made their first contribution in [mermaid-js/mermaid#4825 **Full Changelog**: mermaid-js/mermaid@v10.4.0...v10.5.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/levaintech/contented). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4wLjMiLCJ1cGRhdGVkSW5WZXIiOiIzNy4wLjMiLCJ0YXJnZXRCcmFuY2giOiJtYWluIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Summary
Add back support for
~test Array~string~Context: #4534 (comment)
📏 Design Decisions
We cannot remove that support as it would be a breaking change.
Also, if
~test Intis supported,~test Array~string~should be too.📋 Tasks
Make sure you