Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Node to version 8.12.0 (prerelease). #10090

Closed
wants to merge 13 commits into from

Conversation

benjamn
Copy link
Contributor

@benjamn benjamn commented Jul 20, 2018

As explained by @MylesBorins in the proposal PR for Node 8.12.0, the Node team is planning to have a longer Release Candidate process this time, to give contributors a chance to test everything more thoroughly.

This sounds like a great idea to us! In the spirit of thorough testing, this PR is intended to help vet the Node 8.12.0 changes in the context of Meteor, by running our extensive test suite using the new Node version.

Note: since there isn't an official RC release of Node 8.12.0 yet (keep an eye on https://nodejs.org/download/rc/ for that), and we only have a functional Node build system for Unix platforms, this PR currently applies only to Linux and Mac builds, with Windows still using Node 8.11.3.

I'm not sure what version of Meteor the Node 8.12.0 changes will land in, given the uncertainty of the Node release timeline, and given that #9942 is looking pretty stable these days. We'll put this PR into a milestone once we have a better idea about the timing.

@veered
Copy link
Contributor

veered commented Jul 20, 2018

This only works in dev mode, right?

@benjamn
Copy link
Contributor Author

benjamn commented Jul 20, 2018

If you mean it only works when running Meteor from a checkout, then yes. We haven't released a prerelease version of Meteor with these changes yet.

@benjamn
Copy link
Contributor Author

benjamn commented Jul 20, 2018

Are there any specific changes you're excited about in Node 8.12.0?

@veered
Copy link
Contributor

veered commented Jul 20, 2018

A fix for fiber hell: nodejs/node#20727

The change has been backported to 8.12.0. I think it'll be a massive performance improvement in many meteor apps (and maybe rebuilds as well).

It'll also fix some of the issues people have been having where the CPU gets pegged to 100%.

@benjamn
Copy link
Contributor Author

benjamn commented Aug 3, 2018

Another change that I would very much like to get into V8 and then Node 8.12.0 and then Meteor 1.7.1: https://chromium-review.googlesource.com/c/v8/v8/+/833260

The good news is that we can potentially build our own Node with those changes in the meantime, if the backporting process takes too long.

@veered
Copy link
Contributor

veered commented Aug 16, 2018

The first 8.12.0 RC has been released, and has a target release date of September 4th!

https://nodejs.org/download/rc/v8.12.0-rc.1/

benjamn added a commit that referenced this pull request Sep 11, 2018
@benjamn
Copy link
Contributor Author

benjamn commented Sep 11, 2018

Now available by running

meteor update --release 1.7.1-rc.10

@benjamn benjamn closed this Sep 11, 2018
@benjamn benjamn deleted the update-node-to-8.12.0 branch September 11, 2018 14:43
benjamn added a commit that referenced this pull request Sep 12, 2018
This minor update was evidently too risky to slip into a release candidate
of Meteor 1.7.1: #10216

You can still use Node 8.12.0 to run your app in production, and thus get
the benefits of #10090, even if it's
not the version used in development.
benjamn added a commit that referenced this pull request Oct 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants