New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Node to version 8.12.0 (prerelease). #10090
Conversation
This only works in dev mode, right? |
If you mean it only works when running Meteor from a checkout, then yes. We haven't released a prerelease version of Meteor with these changes yet. |
Are there any specific changes you're excited about in Node 8.12.0? |
A fix for fiber hell: nodejs/node#20727 The change has been backported to 8.12.0. I think it'll be a massive performance improvement in many meteor apps (and maybe rebuilds as well). It'll also fix some of the issues people have been having where the CPU gets pegged to 100%. |
Another change that I would very much like to get into V8 and then Node 8.12.0 and then Meteor 1.7.1: https://chromium-review.googlesource.com/c/v8/v8/+/833260 The good news is that we can potentially build our own Node with those changes in the meantime, if the backporting process takes too long. |
The first 8.12.0 RC has been released, and has a target release date of September 4th! |
Now available by running meteor update --release 1.7.1-rc.10 |
https://nodejs.org/en/blog/release/v8.12.0/ Closes #10117 and #10090. We will continue to monitor issue #10216.
As explained by @MylesBorins in the proposal PR for Node 8.12.0, the Node team is planning to have a longer Release Candidate process this time, to give contributors a chance to test everything more thoroughly.
This sounds like a great idea to us! In the spirit of thorough testing, this PR is intended to help vet the Node 8.12.0 changes in the context of Meteor, by running our extensive test suite using the new Node version.
Note: since there isn't an official RC release of Node 8.12.0 yet (keep an eye on https://nodejs.org/download/rc/ for that), and we only have a functional Node build system for Unix platforms, this PR currently applies only to Linux and Mac builds, with Windows still using Node 8.11.3.
I'm not sure what version of Meteor the Node 8.12.0 changes will land in, given the uncertainty of the Node release timeline, and given that #9942 is looking pretty stable these days. We'll put this PR into a milestone once we have a better idea about the timing.