Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Node to version 8.12.0 (prerelease). #10090

Closed
wants to merge 13 commits into from
Closed

Update Node to version 8.12.0 (prerelease). #10090

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
73bb3fd
Set NODE_VERSION to 8.12.0.
benjamn Jul 20, 2018
316768c
Use git to clone meteor/node branches rather than downloading archives.
benjamn Jul 20, 2018
9bb9533
Set NODE_BUILD_NUMBER=135 for Node 8.12.0.
benjamn Jul 20, 2018
ba46e42
Force Windows to use official Node v8.11.3 for now.
benjamn Jul 20, 2018
9a15c9e
Bump $BUNDLE_VERSION to 8.12.0-pre.0 before rebuilding dev bundle.
benjamn Jul 20, 2018
2e78b47
Merge branch 'release-1.7.1' into update-node-to-8.12.0
benjamn Aug 7, 2018
c66c1a3
Update our build of Node 8.12.0 to include latest upstream commits.
benjamn Aug 8, 2018
5e78a62
Bump $BUNDLE_VERSION to 8.12.0-pre.1 before rebuilding dev bundle.
benjamn Aug 8, 2018
97bdfc4
Merge branch 'release-1.7.1' into update-node-to-8.12.0
benjamn Aug 17, 2018
acc9246
Update all platforms to official Node 8.12.0-rc.1 prerelease.
benjamn Aug 17, 2018
56359aa
Bump $BUNDLE_VERSION to 8.12.0-rc.1 before rebuilding dev bundle.
benjamn Aug 17, 2018
9423845
Update all platforms to official Node 8.12.0-rc.3 prerelease.
benjamn Aug 20, 2018
b56cedf
Bump $BUNDLE_VERSION to 8.12.0-rc.3 before rebuilding dev bundle.
benjamn Aug 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions History.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
## v.NEXT

* Node has been updated to version
[8.12.0-rc.3](https://github.com/nodejs/node/pull/21593).

## v1.7.1, TBD

* Compiler plugins that call `inputFile.addJavaScript` or
Expand Down
2 changes: 1 addition & 1 deletion meteor
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#!/usr/bin/env bash

BUNDLE_VERSION=8.11.4.1
BUNDLE_VERSION=8.12.0-rc.3

# OS Check. Put here because here is where we download the precompiled
# bundles that are arch specific.
Expand Down
2 changes: 1 addition & 1 deletion scripts/build-dev-bundle-common.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ set -u

UNAME=$(uname)
ARCH=$(uname -m)
NODE_VERSION=8.11.4
NODE_VERSION=8.12.0-rc.3
MONGO_VERSION_64BIT=4.0.0
MONGO_VERSION_32BIT=3.2.19
NPM_VERSION=6.3.0
Expand Down
17 changes: 12 additions & 5 deletions scripts/build-node-for-dev-bundle.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,9 @@ then
then
NODE_FROM_SRC=${NODE_FROM_SRC:=true}
echo "Building Node source from Git hash ${NODE_COMMIT_HASH}...";
NODE_URL="https://github.com/meteor/node/archive/${NODE_COMMIT_HASH}.tar.gz"
git clone --branch "$NODE_COMMIT_HASH" --depth 1 \
https://github.com/meteor/node.git \
node-build
else
echo "Building Node source from ${NODE_VERSION} src tarball...";
NODE_URL="https://nodejs.org/dist/v${NODE_VERSION}/node-v${NODE_VERSION}.tar.gz"
Expand All @@ -24,11 +26,16 @@ else
NODE_URL="https://nodejs.org/dist/v${NODE_VERSION}/${NODE_TGZ}"
fi

mkdir node-build
cd node-build
if [ -d node-build ]
then
cd node-build
else
mkdir node-build
cd node-build

echo "Downloading Node from ${NODE_URL}"
curl -sL "${NODE_URL}" | tar zx --strip-components 1
echo "Downloading Node from ${NODE_URL}"
curl -sL "${NODE_URL}" | tar zx --strip-components 1
fi

node_configure_flags=(
# Enable the ICU internationalization library.
Expand Down