Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to disable filters based on the request #10172

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Allow to disable filters based on the request #10172

merged 1 commit into from
Dec 12, 2023

Conversation

dstepanov
Copy link
Contributor

Based on #10167

@dstepanov dstepanov mentioned this pull request Nov 30, 2023
@dstepanov dstepanov marked this pull request as draft December 4, 2023 08:12
@yawkat
Copy link
Member

yawkat commented Dec 4, 2023

is this a measurable improvement?

@dstepanov
Copy link
Contributor Author

This can eliminate the filters entirely, but it will require one small change to improve this.

@yawkat
Copy link
Member

yawkat commented Dec 4, 2023

i get the idea, but in the FullHttpStackBenchmark i doubt there is very much code that is being skipped by this

Base automatically changed from filterr to 4.3.x December 4, 2023 12:12
@dstepanov dstepanov marked this pull request as ready for review December 4, 2023 12:35
Copy link

sonarqubecloud bot commented Dec 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

90.2% 90.2% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants