[BUG] Can't include Correlation Header on IE can fail #1260 #1266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[BUG] ajax.ts is using string trim() which is not supported on IE7/8 #1251
MSNev
commented
May 13, 2020
| @@ -423,7 +423,8 @@ export class Sender extends BaseTelemetryPlugin implements IChannelControlsAI { | |||
| this._retryAt = null; | |||
| } catch (e) { | |||
| /* Ignore this error for IE under v10 */ | |||
| if (!Util.getIEVersion() || Util.getIEVersion() > 9) { | |||
| let ieVer = Util.getIEVersion(); | |||
There was a problem hiding this comment.
Using local var to save space for minification.
MSNev
commented
May 13, 2020
| return (myNav.indexOf('msie') !== -1) ? parseInt(myNav.split('msie')[1]) : null; | ||
| if (myNav.indexOf("msie") !== -1) { | ||
| return parseInt(myNav.split("msie")[1]); | ||
| } else if (myNav.indexOf("trident/")) { |
There was a problem hiding this comment.
Adding trident as not all IE userAgents always include MSIE
MSNev
commented
May 13, 2020
|
|
||
| public static parseUrl(url: string): HTMLAnchorElement { | ||
| if (!UrlHelper.htmlAnchorElement) { | ||
| UrlHelper.htmlAnchorElement = !!UrlHelper.document.createElement ? UrlHelper.document.createElement('a') : { host: UrlHelper.parseHost(url) }; // fill host field in the fallback case as that is the only externally required field from this fn |
There was a problem hiding this comment.
There was a test error with just using the single instance which caused the tests to occasionally fail -- as the used value kept getting overwritten.
MSNev
commented
May 13, 2020
| errorMsg: "[%funcName%] is not supported in an ES3 environment, use CoreUtils.toISOString()", | ||
| ignoreFuncMatch: [ | ||
| "CoreUtils.toISOString", // Make sure this isn't a reference to CoreUtils.isISOString() | ||
| "Utils.toISOString" // or if it's a reference to Utils.isISOString() | ||
| /CoreUtils(\$[\d]+)+\.toISOString/, // Make sure this isn't a reference to CoreUtils.isISOString(); CoreUtils$1.isISOString(); |
There was a problem hiding this comment.
Updating this to support an issue that Xiao was having while attempt to update the version of TypeScript which caused the CoreUtils reference to become CoreUtils$0.toISOString()
MSNev
commented
May 13, 2020
| @@ -190,6 +190,14 @@ export const defaultEs3CheckTokens:IEs3CheckKeyword[] = [ | |||
| { | |||
| funcNames: [ /[\s\(,][gs]et[\s]+([\w]+)[\s]*\(\)[\s]*\{/g ], | |||
| errorMsg: "[%funcName%] is not supported in an ES3 environment." | |||
| }, | |||
| { | |||
| funcNames: [ /([\w0-9]*)\.(trim)[\s]*\(/g ], | |||
There was a problem hiding this comment.
Add check for string trim() which is not supported on ES3
MSNev
changed the title
markwolff
approved these changes
May 20, 2020
This was
linked to
issues
Jun 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[BUG] ajax.ts is using string trim() which is not supported on IE7/8 #1251