fix bad requests causing unit tests to hang #478

markwolff · 2019-01-15T00:29:35Z

Fixes #475

Fix hanging mocha tests
- Stubbed some http(s).request methods in unit tests (fixes our unit tests)
- Fix stubbed http request from returning undefined statusCode
- Unref diskretry timer so that we don't block instrumented app from terminating
Upgrade to latest mocha version (edit: Staying with 3.5 because it breaks node 0.x, but added --no-exit)

Mocha 4+ does not force quit tests on termination, so tests involving application insights would hang for 30-60 seconds due to fetchAppId getting an undefined status code and retrying.

Library/CorrelationIdManager.ts

Library/Sender.ts

fix hanging requests

47906c6

markwolff requested a review from OsvaldoRosado January 15, 2019 00:29

Mark Wolff added 2 commits January 14, 2019 16:40

change mocha to 3.5.2

886dc63

add --no-exit tag to unit tests

24e63d7

markwolff changed the title ~~fix hanging requests~~ fix bad requests causing unit tests to hang Jan 16, 2019

OsvaldoRosado reviewed Jan 18, 2019

View reviewed changes

Library/CorrelationIdManager.ts Outdated Show resolved Hide resolved

unref diskretry timeout to prevent blocking app from terminating

7bf8271

markwolff requested a review from ramthi January 23, 2019 01:21

jpiyali reviewed Jan 23, 2019

View reviewed changes

Library/Sender.ts Show resolved Hide resolved

OsvaldoRosado approved these changes Jan 23, 2019

View reviewed changes

markwolff requested a review from jpiyali January 23, 2019 01:50

jpiyali approved these changes Jan 23, 2019

View reviewed changes

markwolff merged commit 369b91d into develop Jan 23, 2019

markwolff deleted the markwolff/fix-mocha branch January 23, 2019 17:27

markwolff mentioned this pull request Feb 20, 2019

Memory leaks detected #463

Closed

Provide feedback