Skip to content
This repository has been archived by the owner on Nov 16, 2023. It is now read-only.

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 10, 2023

Bumps mockito-inline from 4.6.1 to 4.11.0.

Release notes

Sourced from mockito-inline's releases.

v4.11.0

Changelog generated by Shipkit Changelog Gradle Plugin

4.11.0

v4.10.0

Changelog generated by Shipkit Changelog Gradle Plugin

4.10.0

v4.9.0

Changelog generated by Shipkit Changelog Gradle Plugin

4.9.0

v4.8.1

Changelog generated by Shipkit Changelog Gradle Plugin

4.8.1

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@DaveTryon
Copy link
Collaborator

@dependabot recreate

@dependabot dependabot bot force-pushed the dependabot/gradle/AccessibilityInsightsForAndroidService/app/org.mockito-mockito-inline-4.11.0 branch from e7fa85b to 09c5917 Compare January 10, 2023 22:27
Bumps [mockito-inline](https://github.com/mockito/mockito) from 4.6.1 to 4.11.0.
- [Release notes](https://github.com/mockito/mockito/releases)
- [Commits](mockito/mockito@v4.6.1...v4.11.0)

---
updated-dependencies:
- dependency-name: org.mockito:mockito-inline
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/gradle/AccessibilityInsightsForAndroidService/app/org.mockito-mockito-inline-4.11.0 branch from 09c5917 to 2466f8e Compare January 11, 2023 00:39
@DaveTryon
Copy link
Collaborator

I've looked at this and it looks like a regression in mockito-inline. I've opened mockito/mockito#2860 to ask the mockito team to take a look.

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 16, 2023

Superseded by #200.

@dependabot dependabot bot closed this Jan 16, 2023
@dependabot dependabot bot deleted the dependabot/gradle/AccessibilityInsightsForAndroidService/app/org.mockito-mockito-inline-4.11.0 branch January 16, 2023 06:01
DaveTryon added a commit that referenced this pull request Jan 26, 2023
#### Details

Due to mockito/mockito#2860, Dependbot has
been unable to update to any version of `mockito-inline` since version
4.6.1. The failed attempts are as follows:

Version | Failed PR
--- | ---
4.7.0 | #169 
4.8.0 | #174
4.8.1 | #176
4.9.0 | #182
4.11.0 | #198 

In response to mockito/mockito#2860, a
suggestion was made to use an `ArgumentCaptor` to capture the arguments
and the `RETURNS_SELF` parameter for the builder. This PR makes that
change, so we're now capturing arguments using the construct that is
intended for that purpose. The mockito team has not committed to fixing
this issue and may even be leaning toward not fixing it, since a more
officially supported option exists to do what we're doing.

I've applied these changes locally to #198 and confirmed that the tests
complete as expected.

##### Motivation

Allow newer versions of mockito

##### Context

<!-- Are there any parts that you've intentionally left out-of-scope for
a later PR to handle? -->

<!-- Were there any alternative approaches you considered? What
tradeoffs did you consider? -->

#### Pull request checklist
<!-- If a checklist item is not applicable to this change, write "n/a"
in the checkbox -->

- [n/a] Addresses an existing issue:
- [n/a] Added/updated relevant unit test(s)
- [x] Ran `./gradlew fastpass` from
`AccessibilityInsightsForAndroidService`
- [x] PR title _AND_ final merge commit title both start with a semantic
tag (`fix:`, `chore:`, `feat(feature-name):`, `refactor:`).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
category: engineering dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant