chore: remove default exports [P5] #13934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
requested review from
dvdzkwsk,
dzearing,
ecraig12345,
jurokapsiar,
levithomason,
miroslavstastny,
mnajdova and
pompomon
as code owners
layershifter
added
the
Fluent UI react-northstar (v0)
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit cfa2ab8:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: e7b119a05ef8a4aa254df00320f3672298617ade (build) |
dzearing
approved these changes
Jul 8, 2020
…ub.com/microsoft/fluentui into chore/no-default-export
…ub.com/microsoft/fluentui into chore/no-default-export � Conflicts: � packages/fluentui/react-northstar/src/components/Dropdown/Dropdown.tsx � packages/fluentui/react-northstar/src/utils/AutoControlledComponent.tsx � packages/fluentui/react-northstar/src/utils/UIComponent.tsx � packages/fluentui/react-northstar/src/utils/index.ts � packages/fluentui/react-northstar/test/specs/components/Dropdown/Dropdown-test.tsx
pompomon
reviewed
Jul 10, 2020
| "root": true | ||
| "root": true, | ||
| "rules": { | ||
| "import/no-default-export": "off" |
There was a problem hiding this comment.
Please why it's "off" for e2e?
There was a problem hiding this comment.
e2e is not a part of distributed code so it's not important to fix things there.
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
pompomon
reviewed
Jul 10, 2020
pompomon
reviewed
Jul 10, 2020
| @@ -1,4 +1,5 @@ | |||
| const config = { | |||
| repoURL: 'https://github.com/microsoft/fluentui', | |||
There was a problem hiding this comment.
Should we import it from packages/fluentui/react-northstar/src/utils/constants.ts ? So we don't have to change URL in two places
There was a problem hiding this comment.
constants are no longer reexported under @fluentui/react-northstar (I think that this variable was exported by a mistake).
pompomon
approved these changes
Jul 10, 2020
Co-authored-by: Roman Sudarikov <pompomon@users.noreply.github.com>
…ub.com/microsoft/fluentui into chore/no-default-export
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR is a fifth round of
defaultexports removal, see #12953 (comment).