Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: mark 1.23.4 #15731

Merged
merged 2 commits into from Jul 16, 2022
Merged

chore: mark 1.23.4 #15731

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a286a43
chore: mark 1.23.4
yury-s Jul 15, 2022
e40a134
Update docs after running npm run lint
yury-s Jul 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 5 additions & 5 deletions docs/src/ci.md
View file
Open in desktop
Expand Up @@ -143,7 +143,7 @@ Alternatively, you can use [Command line tools](./cli.md#install-system-dependen
pool:
vmImage: 'ubuntu-20.04'

container: mcr.microsoft.com/playwright:v1.23.3-focal
container: mcr.microsoft.com/playwright:v1.23.4-focal

steps:
...
Expand All @@ -157,7 +157,7 @@ Running Playwright on CircleCI requires the following steps:

```yml
docker:
- image: mcr.microsoft.com/playwright:v1.23.3-focal
- image: mcr.microsoft.com/playwright:v1.23.4-focal
environment:
NODE_ENV: development # Needed if playwright is in `devDependencies`
```
Expand All @@ -179,7 +179,7 @@ to run tests on Jenkins.

```groovy
pipeline {
agent { docker { image 'mcr.microsoft.com/playwright:v1.23.3-focal' } }
agent { docker { image 'mcr.microsoft.com/playwright:v1.23.4-focal' } }
stages {
stage('e2e-tests') {
steps {
Expand All @@ -196,7 +196,7 @@ pipeline {
Bitbucket Pipelines can use public [Docker images as build environments](https://confluence.atlassian.com/bitbucket/use-docker-images-as-build-environments-792298897.html). To run Playwright tests on Bitbucket, use our public Docker image ([see Dockerfile](./docker.md)).

```yml
image: mcr.microsoft.com/playwright:v1.23.3-focal
image: mcr.microsoft.com/playwright:v1.23.4-focal
```

### GitLab CI
Expand All @@ -209,7 +209,7 @@ stages:

tests:
stage: test
image: mcr.microsoft.com/playwright:v1.23.3-focal
image: mcr.microsoft.com/playwright:v1.23.4-focal
script:
...
```
Expand Down
24 changes: 12 additions & 12 deletions docs/src/docker.md
View file
Open in desktop
Expand Up @@ -14,19 +14,19 @@ This image is published on [Docker Hub].
### Pull the image

```bash js
docker pull mcr.microsoft.com/playwright:v1.23.3-focal
docker pull mcr.microsoft.com/playwright:v1.23.4-focal
```

```bash python
docker pull mcr.microsoft.com/playwright/python:v1.23.3-focal
docker pull mcr.microsoft.com/playwright/python:v1.23.4-focal
```

```bash csharp
docker pull mcr.microsoft.com/playwright/dotnet:v1.23.3-focal
docker pull mcr.microsoft.com/playwright/dotnet:v1.23.4-focal
```

```bash java
docker pull mcr.microsoft.com/playwright/java:v1.23.3-focal
docker pull mcr.microsoft.com/playwright/java:v1.23.4-focal
```

### Run the image
Expand All @@ -38,39 +38,39 @@ By default, the Docker image will use the `root` user to run the browsers. This
On trusted websites, you can avoid creating a separate user and use root for it since you trust the code which will run on the browsers.

```bash js
docker run -it --rm --ipc=host mcr.microsoft.com/playwright:v1.23.3-focal /bin/bash
docker run -it --rm --ipc=host mcr.microsoft.com/playwright:v1.23.4-focal /bin/bash
```

```bash python
docker run -it --rm --ipc=host mcr.microsoft.com/playwright/python:v1.23.3-focal /bin/bash
docker run -it --rm --ipc=host mcr.microsoft.com/playwright/python:v1.23.4-focal /bin/bash
```

```bash csharp
docker run -it --rm --ipc=host mcr.microsoft.com/playwright/dotnet:v1.23.3-focal /bin/bash
docker run -it --rm --ipc=host mcr.microsoft.com/playwright/dotnet:v1.23.4-focal /bin/bash
```

```bash java
docker run -it --rm --ipc=host mcr.microsoft.com/playwright/java:v1.23.3-focal /bin/bash
docker run -it --rm --ipc=host mcr.microsoft.com/playwright/java:v1.23.4-focal /bin/bash
```

#### Crawling and scraping

On untrusted websites, it's recommended to use a separate user for launching the browsers in combination with the seccomp profile. Inside the container or if you are using the Docker image as a base image you have to use `adduser` for it.

```bash js
docker run -it --rm --ipc=host --user pwuser --security-opt seccomp=seccomp_profile.json mcr.microsoft.com/playwright:v1.23.3-focal /bin/bash
docker run -it --rm --ipc=host --user pwuser --security-opt seccomp=seccomp_profile.json mcr.microsoft.com/playwright:v1.23.4-focal /bin/bash
```

```bash python
docker run -it --rm --ipc=host --user pwuser --security-opt seccomp=seccomp_profile.json mcr.microsoft.com/playwright/python:v1.23.3-focal /bin/bash
docker run -it --rm --ipc=host --user pwuser --security-opt seccomp=seccomp_profile.json mcr.microsoft.com/playwright/python:v1.23.4-focal /bin/bash
```

```bash csharp
docker run -it --rm --ipc=host --user pwuser --security-opt seccomp=seccomp_profile.json mcr.microsoft.com/playwright/dotnet:v1.23.3-focal /bin/bash
docker run -it --rm --ipc=host --user pwuser --security-opt seccomp=seccomp_profile.json mcr.microsoft.com/playwright/dotnet:v1.23.4-focal /bin/bash
```

```bash java
docker run -it --rm --ipc=host --user pwuser --security-opt seccomp=seccomp_profile.json mcr.microsoft.com/playwright/java:v1.23.3-focal /bin/bash
docker run -it --rm --ipc=host --user pwuser --security-opt seccomp=seccomp_profile.json mcr.microsoft.com/playwright/java:v1.23.4-focal /bin/bash
```

[`seccomp_profile.json`](https://github.com/microsoft/playwright/blob/main/utils/docker/seccomp_profile.json) is needed to run Chromium with sandbox. This is a [default Docker seccomp profile](https://github.com/docker/engine/blob/d0d99b04cf6e00ed3fc27e81fc3d94e7eda70af3/profiles/seccomp/default.json) with extra user namespace cloning permissions:
Expand Down
2 changes: 1 addition & 1 deletion docs/src/release-notes-js.md
View file
Open in desktop
Expand Up @@ -106,7 +106,7 @@ Read more about [component testing with Playwright](./test-components).
}
});
```
* Playwright now runs on Ubuntu 22 amd64 and Ubuntu 22 arm64. We also publish new docker image `mcr.microsoft.com/playwright:v1.23.3-jammy`.
* Playwright now runs on Ubuntu 22 amd64 and Ubuntu 22 arm64. We also publish new docker image `mcr.microsoft.com/playwright:v1.23.4-jammy`.

### ⚠️ Breaking Changes ⚠️

Expand Down
2 changes: 1 addition & 1 deletion docs/src/test-snapshots-js.md
View file
Open in desktop
Expand Up @@ -56,7 +56,7 @@ The snapshot name `example-test-1-chromium-darwin.png` consists of a few parts:
If you are not on the same operating system as your CI system, you can use Docker to generate/update the screenshots:

```bash
docker run --rm --network host -v $(pwd):/work/ -w /work/ -it mcr.microsoft.com/playwright:v1.23.3-focal /bin/bash
docker run --rm --network host -v $(pwd):/work/ -w /work/ -it mcr.microsoft.com/playwright:v1.23.4-focal /bin/bash
npm install
npx playwright test --update-snapshots
```
Expand Down
60 changes: 30 additions & 30 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
@@ -1,7 +1,7 @@
{
"name": "playwright-internal",
"private": true,
"version": "1.23.3",
"version": "1.23.4",
"description": "A high-level API to automate web browsers",
"repository": "github:Microsoft/playwright",
"homepage": "https://playwright.dev",
Expand Down
4 changes: 2 additions & 2 deletions packages/playwright-chromium/package.json
View file
Open in desktop
@@ -1,6 +1,6 @@
{
"name": "playwright-chromium",
"version": "1.23.3",
"version": "1.23.4",
"description": "A high-level API to automate Chromium",
"repository": "github:Microsoft/playwright",
"homepage": "https://playwright.dev",
Expand All @@ -27,6 +27,6 @@
"install": "node install.js"
},
"dependencies": {
"playwright-core": "1.23.3"
"playwright-core": "1.23.4"
}
}
2 changes: 1 addition & 1 deletion packages/playwright-core/package.json
View file
Open in desktop
@@ -1,6 +1,6 @@
{
"name": "playwright-core",
"version": "1.23.3",
"version": "1.23.4",
"description": "A high-level API to automate web browsers",
"repository": "github:Microsoft/playwright",
"homepage": "https://playwright.dev",
Expand Down