New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
devops: refactor GitHub Actions workflows #30524
Conversation
is-linux: true | ||
validate-coverage: ${{ matrix.browser }} | ||
browser-to-install: ${{ matrix.browser }} | ||
command: npm run test -- --project=${{ matrix.browser }}-* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- We'll also need env for trace/video/etc bots.
- I'd also make "PWTEST_BOT_NAME" an argument.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think passing the env is simpler than plumbing it via an input
option and setting it as an env var again and easier to understand?
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
bot-name: | ||
description: 'Bot name' | ||
required: true | ||
flakiness-client-id: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can it be declared as a secret:
and propagated automatically from the calling workflow without explicitly mentioning these 3 all the time?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately not. Composite Actions don't have access to secrets/vars as per here.
bc37b9e
to
01682e9
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Test results for "tests 1"2 flaky27277 passed, 671 skipped Merge workflow run. |
Test results for "tests 2"4 fatal errors, not part of any test 54 flaky169038 passed, 7580 skipped, 2617 did not run Merge workflow run. |
https://github.com/microsoft/playwright-internal/issues/203