New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
devops: refactor GitHub Actions workflows #30524
Merged
+316
−870
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,87 @@ | ||
name: 'Run browser tests' | ||
description: 'Run browser tests' | ||
inputs: | ||
command: | ||
description: 'Command to run tests' | ||
required: true | ||
node-version: | ||
description: 'Node.js version to use' | ||
required: false | ||
default: '18' | ||
browsers-to-install: | ||
description: 'Browser to install. Default is all browsers.' | ||
required: false | ||
default: '' | ||
bot-name: | ||
description: 'Bot name' | ||
required: true | ||
shell: | ||
description: 'Shell to use' | ||
required: false | ||
default: 'bash' | ||
flakiness-client-id: | ||
description: 'Azure Flakiness Dashboard Client ID' | ||
required: false | ||
flakiness-tenant-id: | ||
description: 'Azure Flakiness Dashboard Tenant ID' | ||
required: false | ||
flakiness-subscription-id: | ||
description: 'Azure Flakiness Dashboard Subscription ID' | ||
required: false | ||
|
||
runs: | ||
using: composite | ||
steps: | ||
- uses: actions/setup-node@v4 | ||
with: | ||
node-version: ${{ inputs.node-version }} | ||
# https://github.com/actions/runner-images/issues/9330 | ||
- name: Allow microphone access to all apps (macOS 14) | ||
shell: bash | ||
run: | | ||
if [[ "$(uname)" == "Darwin" && "$(sw_vers -productVersion | cut -d. -f1)" == "14" ]]; then | ||
echo "Allowing microphone access to all apps" | ||
sqlite3 $HOME/Library/Application\ Support/com.apple.TCC/TCC.db "INSERT OR IGNORE INTO access VALUES ('kTCCServiceMicrophone','/usr/local/opt/runner/provisioner/provisioner',1,2,4,1,NULL,NULL,0,'UNUSED',NULL,0,1687786159,NULL,NULL,'UNUSED',1687786159);" | ||
fi | ||
- run: npm ci | ||
shell: bash | ||
env: | ||
DEBUG: pw:install | ||
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: '1' | ||
- run: npm run build | ||
shell: bash | ||
- run: npx playwright install --with-deps ${{ inputs.browsers-to-install }} | ||
shell: bash | ||
- name: Run tests | ||
if: inputs.shell == 'bash' | ||
run: | | ||
if [[ "$(uname)" == "Linux" ]]; then | ||
xvfb-run --auto-servernum --server-args="-screen 0 1280x960x24" -- ${{ inputs.command }} | ||
else | ||
${{ inputs.command }} | ||
fi | ||
shell: bash | ||
env: | ||
PWTEST_BOT_NAME: ${{ inputs.bot-name }} | ||
- name: Run tests | ||
if: inputs.shell != 'bash' | ||
run: ${{ inputs.command }} | ||
shell: ${{ inputs.shell }} | ||
env: | ||
PWTEST_BOT_NAME: ${{ inputs.bot-name }} | ||
- name: Azure Login | ||
uses: azure/login@v2 | ||
if: ${{ !cancelled() && github.event_name == 'push' && github.repository == 'microsoft/playwright' }} | ||
with: | ||
client-id: ${{ inputs.flakiness-client-id }} | ||
tenant-id: ${{ inputs.flakiness-tenant-id }} | ||
subscription-id: ${{ inputs.flakiness-subscription-id }} | ||
- run: ./utils/upload_flakiness_dashboard.sh ./test-results/report.json | ||
if: ${{ !cancelled() }} | ||
shell: bash | ||
- name: Upload blob report | ||
if: ${{ !cancelled() }} | ||
uses: ./.github/actions/upload-blob-report | ||
with: | ||
report_dir: blob-report | ||
job_name: ${{ inputs.bot-name }} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -42,39 +42,20 @@ jobs: | |
node-version: 20 | ||
browser: chromium | ||
runs-on: ${{ matrix.os }} | ||
env: | ||
PWTEST_BOT_NAME: "${{ matrix.browser }}-${{ matrix.os }}-node${{ matrix.node-version }}" | ||
permissions: | ||
id-token: write # This is required for OIDC login (azure/login) to succeed | ||
contents: read # This is required for actions/checkout to succeed | ||
steps: | ||
- uses: actions/checkout@v4 | ||
- uses: actions/setup-node@v4 | ||
- uses: ./.github/actions/run-test | ||
with: | ||
node-version: ${{ matrix.node-version }} | ||
- run: npm ci | ||
env: | ||
DEBUG: pw:install | ||
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 | ||
- run: npm run build | ||
- run: npx playwright install --with-deps ${{ matrix.browser }} chromium | ||
- run: xvfb-run --auto-servernum --server-args="-screen 0 1280x960x24" -- npm run test -- --project=${{ matrix.browser }}-* | ||
- name: Azure Login | ||
uses: azure/login@v2 | ||
if: ${{ !cancelled() && github.event_name == 'push' && github.repository == 'microsoft/playwright' }} | ||
with: | ||
client-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_CLIENT_ID }} | ||
tenant-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_TENANT_ID }} | ||
subscription-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_SUBSCRIPTION_ID }} | ||
- run: ./utils/upload_flakiness_dashboard.sh ./test-results/report.json | ||
if: ${{ !cancelled() }} | ||
shell: bash | ||
- name: Upload blob report | ||
if: ${{ !cancelled() }} | ||
uses: ./.github/actions/upload-blob-report | ||
with: | ||
report_dir: blob-report | ||
job_name: ${{ env.PWTEST_BOT_NAME }} | ||
browsers-to-install: ${{ matrix.browser }} chromium | ||
command: npm run test -- --project=${{ matrix.browser }}-* | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think passing the env is simpler than plumbing it via an |
||
bot-name: "${{ matrix.browser }}-${{ matrix.os }}-node${{ matrix.node-version }}" | ||
flakiness-client-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_CLIENT_ID }} | ||
flakiness-tenant-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_TENANT_ID }} | ||
flakiness-subscription-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_SUBSCRIPTION_ID }} | ||
|
||
test_linux_chromium_tot: | ||
name: ${{ matrix.os }} (chromium tip-of-tree) | ||
|
@@ -84,42 +65,21 @@ jobs: | |
matrix: | ||
os: [ubuntu-20.04] | ||
runs-on: ${{ matrix.os }} | ||
env: | ||
PWTEST_BOT_NAME: "${{ matrix.os }}-chromium-tip-of-tree" | ||
permissions: | ||
id-token: write # This is required for OIDC login (azure/login) to succeed | ||
contents: read # This is required for actions/checkout to succeed | ||
steps: | ||
- uses: actions/checkout@v4 | ||
- uses: actions/setup-node@v4 | ||
with: | ||
node-version: 18 | ||
- run: npm ci | ||
env: | ||
DEBUG: pw:install | ||
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 | ||
- run: npm run build | ||
- run: npx playwright install --with-deps chromium-tip-of-tree | ||
- run: xvfb-run --auto-servernum --server-args="-screen 0 1280x960x24" -- npm run test -- --project=chromium-* | ||
- uses: ./.github/actions/run-test | ||
with: | ||
browsers-to-install: chromium-tip-of-tree | ||
command: npm run test -- --project=chromium-* | ||
bot-name: "${{ matrix.os }}-chromium-tip-of-tree" | ||
flakiness-client-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_CLIENT_ID }} | ||
flakiness-tenant-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_TENANT_ID }} | ||
flakiness-subscription-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_SUBSCRIPTION_ID }} | ||
env: | ||
PWTEST_CHANNEL: chromium-tip-of-tree | ||
PWTEST_BOT_NAME: "${{ matrix.os }}-chromium-tip-of-tree" | ||
- name: Azure Login | ||
uses: azure/login@v2 | ||
if: ${{ !cancelled() && github.event_name == 'push' && github.repository == 'microsoft/playwright' }} | ||
with: | ||
client-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_CLIENT_ID }} | ||
tenant-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_TENANT_ID }} | ||
subscription-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_SUBSCRIPTION_ID }} | ||
- run: ./utils/upload_flakiness_dashboard.sh ./test-results/report.json | ||
if: ${{ !cancelled() }} | ||
shell: bash | ||
- name: Upload blob report | ||
if: ${{ !cancelled() }} | ||
uses: ./.github/actions/upload-blob-report | ||
with: | ||
report_dir: blob-report | ||
job_name: ${{ env.PWTEST_BOT_NAME }} | ||
|
||
test_test_runner: | ||
name: Test Runner | ||
|
@@ -149,41 +109,21 @@ jobs: | |
shardIndex: 2 | ||
shardTotal: 2 | ||
runs-on: ${{ matrix.os }} | ||
env: | ||
PWTEST_BOT_NAME: "${{ matrix.os }}-node${{ matrix.node-version }}-${{ matrix.shardIndex }}" | ||
permissions: | ||
id-token: write # This is required for OIDC login (azure/login) to succeed | ||
contents: read # This is required for actions/checkout to succeed | ||
steps: | ||
- uses: actions/checkout@v4 | ||
- uses: actions/setup-node@v4 | ||
- uses: ./.github/actions/run-test | ||
with: | ||
node-version: ${{matrix.node-version}} | ||
- run: npm ci | ||
command: npm run ttest -- --shard ${{ matrix.shardIndex }}/${{ matrix.shardTotal }} | ||
bot-name: "${{ matrix.os }}-node${{ matrix.node-version }}-${{ matrix.shardIndex }}" | ||
flakiness-client-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_CLIENT_ID }} | ||
flakiness-tenant-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_TENANT_ID }} | ||
flakiness-subscription-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_SUBSCRIPTION_ID }} | ||
env: | ||
DEBUG: pw:install | ||
- run: npm run build | ||
- run: npx playwright install --with-deps | ||
- run: npm run ttest -- --shard ${{ matrix.shardIndex }}/${{ matrix.shardTotal }} | ||
if: matrix.os != 'ubuntu-latest' | ||
- run: xvfb-run npm run ttest -- --shard ${{ matrix.shardIndex }}/${{ matrix.shardTotal }} | ||
if: matrix.os == 'ubuntu-latest' | ||
- name: Azure Login | ||
uses: azure/login@v2 | ||
if: ${{ !cancelled() && github.event_name == 'push' && github.repository == 'microsoft/playwright' }} | ||
with: | ||
client-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_CLIENT_ID }} | ||
tenant-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_TENANT_ID }} | ||
subscription-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_SUBSCRIPTION_ID }} | ||
- run: ./utils/upload_flakiness_dashboard.sh ./test-results/report.json | ||
if: ${{ !cancelled() }} | ||
shell: bash | ||
- name: Upload blob report | ||
if: ${{ !cancelled() }} | ||
uses: ./.github/actions/upload-blob-report | ||
with: | ||
report_dir: blob-report | ||
job_name: ${{ env.PWTEST_BOT_NAME }} | ||
PWTEST_CHANNEL: firefox-beta | ||
|
||
test_web_components: | ||
name: Web Components | ||
|
@@ -268,40 +208,19 @@ jobs: | |
- windows-latest | ||
runs-on: ${{ matrix.os }} | ||
timeout-minutes: 30 | ||
env: | ||
PWTEST_BOT_NAME: "package-installations-${{ matrix.os }}" | ||
permissions: | ||
id-token: write # This is required for OIDC login (azure/login) to succeed | ||
contents: read # This is required for actions/checkout to succeed | ||
steps: | ||
- uses: actions/checkout@v4 | ||
- uses: actions/setup-node@v4 | ||
with: | ||
node-version: 18 | ||
- run: npm ci | ||
env: | ||
DEBUG: pw:install | ||
- run: npm run build | ||
- run: npx playwright install --with-deps | ||
- run: npm install -g yarn@1 | ||
- run: npm install -g pnpm@8 | ||
- run: npm run itest | ||
if: matrix.os != 'ubuntu-latest' | ||
- run: xvfb-run --auto-servernum --server-args="-screen 0 1280x960x24" -- npm run itest | ||
if: matrix.os == 'ubuntu-latest' | ||
- name: Azure Login | ||
uses: azure/login@v2 | ||
if: ${{ !cancelled() && github.event_name == 'push' && github.repository == 'microsoft/playwright' }} | ||
with: | ||
client-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_CLIENT_ID }} | ||
tenant-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_TENANT_ID }} | ||
subscription-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_SUBSCRIPTION_ID }} | ||
- run: ./utils/upload_flakiness_dashboard.sh ./test-results/report.json | ||
if: ${{ !cancelled() }} | ||
shell: bash | ||
- name: Upload blob report | ||
if: ${{ !cancelled() }} | ||
uses: ./.github/actions/upload-blob-report | ||
with: | ||
report_dir: blob-report | ||
job_name: ${{ env.PWTEST_BOT_NAME }} | ||
- uses: ./.github/actions/run-test | ||
with: | ||
command: npm run itest | ||
bot-name: "package-installations-${{ matrix.os }}" | ||
# TODO: figure out why itest fails with 'bash' on Windows. | ||
shell: ${{ matrix.os == 'windows-latest' && 'pwsh' || 'bash' }} | ||
flakiness-client-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_CLIENT_ID }} | ||
flakiness-tenant-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_TENANT_ID }} | ||
flakiness-subscription-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_SUBSCRIPTION_ID }} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can it be declared as a
secret:
and propagated automatically from the calling workflow without explicitly mentioning these 3 all the time?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately not. Composite Actions don't have access to secrets/vars as per here.