Fix code coverage

build/ci/templates/steps/generate_upload_coverage.yml

@@ -15,7 +15,7 @@ steps:
         summaryFileLocation: "$(System.DefaultWorkingDirectory)/coverage/cobertura-coverage.xml"
         reportDirectory: "$(System.DefaultWorkingDirectory)/coverage"
 
-    - bash: cat ./coverage/lcov.info | ./node_modules/.bin/codecov --pipe
+    - bash: cat ./coverage/cobertura-coverage.xml | ./node_modules/.bin/codecov --pipe
       displayName: 'Upload coverage to codecov'
       continueOnError: true
       condition: contains(variables['TestsToRun'], 'testUnitTests')

build/ci/templates/steps/merge_upload_coverage.yml

@@ -4,16 +4,32 @@ steps:
         workingDirectory: $(Build.SourcesDirectory)
         compile: 'false'
 
-    - task: DownloadBuildArtifacts@0
+    # - task: DownloadBuildArtifacts@0
+    #   inputs:
+    #       buildType: "current"
+    #       allowPartiallySucceededBuilds: true
+    #       downloadType: "Specific"
+    #       itemPattern: "**/.nyc_output/**"
+    #       downloadPath: "$(Build.SourcesDirectory)"
+    #   displayName: "Restore Coverage Info"
+    #   condition: always()
+
+    # Download previously generated coverage artifacts
+    - task: DownloadPipelineArtifact@2
       inputs:
-          buildType: "current"
-          allowPartiallySucceededBuilds: true
-          downloadType: "Specific"
-          itemPattern: "**/.nyc_output/**"
-          downloadPath: "$(Build.SourcesDirectory)"
-      displayName: "Restore Coverage Info"
+        patterns: '**/.nyc_output/**'
+      displayName: "Download .nyc_output coverage artifacts"
       condition: always()
 
+    - bash: |
+        pwd
+        cd $(Pipeline.Workspace)
+        pwd
+        ls -dlU .*/ */
+        ls
+      displayName: "See the content of Pipeline.Workspace dir"
+      condition: always()        
+
     # Now that we have downloaded artifacts from `coverage-output-`, copy them
     #   into the root directory (they'll go under `.nyc_output/...`)
     # These are the coverage output files that can be merged and then we can generate a report from them.

build/ci/templates/test_phases.yml

@@ -481,5 +481,5 @@ steps:
   - task: PublishBuildArtifacts@1
     inputs:
       pathtoPublish: $(Build.ArtifactStagingDirectory)
-      artifactName: $(Agent.JobName)
+      artifactName: 'coverage-output-$(Agent.Os)'
     condition: always()

build/ci/vscode-python-pr-validation.yaml

@@ -18,9 +18,9 @@ variables:
 - template: templates/globals.yml
 
 stages:
-- stage: Build
-  jobs:
-  - template: templates/jobs/build_compile.yml
+# - stage: Build
+#   jobs:
+#   - template: templates/jobs/build_compile.yml
 
 - stage: Tests
   dependsOn: []
@@ -44,86 +44,85 @@ stages:
           VMImageName: 'vs2017-win2016'
           TestsToRun: 'testUnitTests, pythonUnitTests, pythonInternalTools'
           NeedsPythonTestReqs: true
-        'Win-Py2.7 Unit':
-          PythonVersion: '2.7'
-          VMImageName: 'vs2017-win2016'
-          TestsToRun: 'pythonUnitTests'
-          NeedsPythonTestReqs: true
+        # 'Win-Py2.7 Unit':
+        #   PythonVersion: '2.7'
+        #   VMImageName: 'vs2017-win2016'
+        #   TestsToRun: 'pythonUnitTests'
+        #   NeedsPythonTestReqs: true
         'Mac-Py3.7 Unit':
           PythonVersion: '3.7'
           VMImageName: 'macos-10.13'
           TestsToRun: 'testUnitTests, pythonUnitTests, pythonInternalTools'
           NeedsPythonTestReqs: true
-        'Mac-Py3.7 Single Workspace':
-          PythonVersion: '3.7'
-          VMImageName: 'macos-10.13'
-          TestsToRun: 'testSingleWorkspace'
-          NeedsPythonTestReqs: true
-        'Mac-Py2.7 Unit+Single':
-          PythonVersion: '2.7'
-          VMImageName: 'macos-10.13'
-          TestsToRun: 'pythonUnitTests, testSingleWorkspace'
-          NeedsPythonTestReqs: true
+        # 'Mac-Py3.7 Single Workspace':
+        #   PythonVersion: '3.7'
+        #   VMImageName: 'macos-10.13'
+        #   TestsToRun: 'testSingleWorkspace'
+        #   NeedsPythonTestReqs: true
+        # 'Mac-Py2.7 Unit+Single':
+        #   PythonVersion: '2.7'
+        #   VMImageName: 'macos-10.13'
+        #   TestsToRun: 'pythonUnitTests, testSingleWorkspace'
+        #   NeedsPythonTestReqs: true
         'Linux-Py3.7 Unit':
           PythonVersion: '3.7'
           VMImageName: 'ubuntu-16.04'
           TestsToRun: 'testUnitTests, pythonUnitTests, pythonInternalTools'
           NeedsPythonTestReqs: true
-        'Linux-Py3.7 Single Workspace':
-          PythonVersion: '3.7'
-          VMImageName: 'ubuntu-16.04'
-          TestsToRun: 'testSingleWorkspace'
-          NeedsPythonTestReqs: true
-        'Linux-Py2.7 Unit+Single':
-          PythonVersion: '2.7'
-          VMImageName: 'ubuntu-16.04'
-          TestsToRun: 'pythonUnitTests, testSingleWorkspace'
-          NeedsPythonTestReqs: true
-        'Linux-Py3.7 Functional':
-          PythonVersion: '3.7'
-          VMImageName: 'ubuntu-16.04'
-          TestsToRun: 'testfunctional'
-          NeedsPythonTestReqs: true
-          NeedsPythonFunctionalReqs: true
+        # 'Linux-Py3.7 Single Workspace':
+        #   PythonVersion: '3.7'
+        #   VMImageName: 'ubuntu-16.04'
+        #   TestsToRun: 'testSingleWorkspace'
+        #   NeedsPythonTestReqs: true
+        # 'Linux-Py2.7 Unit+Single':
+        #   PythonVersion: '2.7'
+        #   VMImageName: 'ubuntu-16.04'
+        #   TestsToRun: 'pythonUnitTests, testSingleWorkspace'
+        #   NeedsPythonTestReqs: true
+        # 'Linux-Py3.7 Functional':
+        #   PythonVersion: '3.7'
+        #   VMImageName: 'ubuntu-16.04'
+        #   TestsToRun: 'testfunctional'
+        #   NeedsPythonTestReqs: true
+        #   NeedsPythonFunctionalReqs: true
 
     pool:
       vmImage: $(VMImageName)
 
     steps:
       - template: templates/test_phases.yml
 
-- stage: Smoke
-  dependsOn: []
-  jobs:
-  - job: 'Smoke'
-    dependsOn: []
-    strategy:
-      matrix:
-        'Mac-Py3.7':
-            PythonVersion: '3.7'
-            VMImageName: 'macos-10.13'
-            TestsToRun: 'testSmoke'
-            NeedsPythonTestReqs: true
-        'Linux-Py3.7':
-            PythonVersion: '3.7'
-            VMImageName: 'ubuntu-16.04'
-            TestsToRun: 'testSmoke'
-            NeedsPythonTestReqs: true
-        'Win-Py3.7':
-            PythonVersion: '3.7'
-            VMImageName: 'vs2017-win2016'
-            TestsToRun: 'testSmoke'
-            NeedsPythonTestReqs: true
+# - stage: Smoke
+#   dependsOn: []
+#   jobs:
+#   - job: 'Smoke'
+#     dependsOn: []
+#     strategy:
+#       matrix:
+#         'Mac-Py3.7':
+#             PythonVersion: '3.7'
+#             VMImageName: 'macos-10.13'
+#             TestsToRun: 'testSmoke'
+#             NeedsPythonTestReqs: true
+#         'Linux-Py3.7':
+#             PythonVersion: '3.7'
+#             VMImageName: 'ubuntu-16.04'
+#             TestsToRun: 'testSmoke'
+#             NeedsPythonTestReqs: true
+#         'Win-Py3.7':
+#             PythonVersion: '3.7'
+#             VMImageName: 'vs2017-win2016'
+#             TestsToRun: 'testSmoke'
+#             NeedsPythonTestReqs: true
 
-    pool:
-      vmImage: $(VMImageName)
+#     pool:
+#       vmImage: $(VMImageName)
 
-    steps:
-      - template: templates/test_phases.yml
+#     steps:
+#       - template: templates/test_phases.yml
 
 - stage: Reports
   dependsOn:
-  - Smoke
   - Tests
   condition: always()
   jobs:

package.json

@@ -2678,7 +2678,7 @@
         "test:unittests:cover": "nyc --silent --no-clean --nycrc-path build/.nycrc mocha --opts ./build/.mocha.unittests.ts.opts",
         "test:functional": "mocha --require source-map-support/register --opts ./build/.mocha.functional.opts",
         "test:functional:cover": "npm run test:functional",
-        "test:cover:report": "nyc --nycrc-path build/.nycrc  report --reporter=lcov --reporter=text --reporter=html --reporter=text-summary --reporter=cobertura",
+        "test:cover:report": "nyc --nycrc-path build/.nycrc  report --reporter=text --reporter=html --reporter=text-summary --reporter=cobertura",
         "testDebugger": "node ./out/test/testBootstrap.js ./out/test/debuggerTest.js",
         "testSingleWorkspace": "node ./out/test/testBootstrap.js ./out/test/standardTest.js",
         "testMultiWorkspace": "node ./out/test/testBootstrap.js ./out/test/multiRootTest.js",