Fix code coverage #8663
Closed
Fix code coverage #8663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
kimadeline
force-pushed
the
8625-code-coverage
branch
from
7bf047c
to
11f7ef8
Compare
10 tasks
| @@ -481,5 +481,5 @@ steps: | |||
| - task: PublishBuildArtifacts@1 | |||
| inputs: | |||
| pathtoPublish: $(Build.ArtifactStagingDirectory) | |||
| artifactName: $(Agent.JobName) | |||
| artifactName: 'coverage-output-$(Agent.Os)' | |||
There was a problem hiding this comment.
This is based on the assumption that we'll only have coverage reports from 3 jobs (one for each OS).
In the past we had coverage reports from others tests as well, may have changed since, please double check.
There was a problem hiding this comment.
That's what we have at the moment, I took this from the PublishBuildArtifacts@1 step in build/ci/templates/test_phases.yml
Merged
|
AzDO stopped triggering builds for this PR 🤷♀ come over and take a look at #8694 instead. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #8615
See
nyc --allistanbuljs/istanbuljs#456 )package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)