Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd: add kes ls command #464

Merged
merged 1 commit into from
May 16, 2024
Merged

cmd: add kes ls command #464

merged 1 commit into from
May 16, 2024

Conversation

aead
Copy link
Member

@aead aead commented May 16, 2024

This commit adds the kes ls command that lists keys, policies and identities.

Usage:
    kes ls [-a KEY] [-k] [--json] [-i] [-p] [-s HOST[:PORT]] [PREFIX]

Options:
    -a, --api-key KEY           API key to authenticate to the KES server.
                                Defaults to $MINIO_KES_API_KEY.
    -s, --server HOST[:PORT]    Use the server HOST[:PORT] instead of
                                $MINIO_KES_SERVER.
        --json                  Print output in JSON format.
    -i, --identity              List identities.
    -p, --policy                List policy names.
    -k, --insecure              Skip server certificate verification.

This command replaces kes key ls, kes policy ls and kes identity ls mid-term.

@aead aead added this to the New CLI milestone May 16, 2024
@shtripat
Copy link
Contributor

please fix vuln check

Vulnerability #1: GO-2024-2824
    Malformed DNS message can cause infinite loop in net
  More info: https://pkg.go.dev/vuln/GO-2024-2824
  Standard library
    Found in: net@go1.22.2
    Fixed in: net@go1.22.3
    Example traces found:

shtripat
shtripat reviewed May 16, 2024
View reviewed changes
Copy link
Contributor

@shtripat shtripat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works as expected.

cmd/kes/flags.go Show resolved Hide resolved
@aead
cmd: add kes ls command
db15379 
This commit adds the `kes ls` command that lists keys, policies and
identities.
```
Usage:
    kes ls [-a KEY] [-k] [--json] [-i] [-p] [-s HOST[:PORT]] [PREFIX]

Options:
    -a, --api-key KEY           API key to authenticate to the KES server.
                                Defaults to $MINIO_KES_API_KEY.
    -s, --server HOST[:PORT]    Use the server HOST[:PORT] instead of
                                $MINIO_KES_SERVER.
        --json                  Print output in JSON format.
    -i, --identity              List identities.
    -p, --policy                List policy names.
    -k, --insecure              Skip server certificate verification.
```

This command replaces `kes key ls`, `kes policy ls` and `kes identity ls`
mid-term.

Signed-off-by: Andreas Auernhammer <github@aead.dev>
@aead aead requested a review from shtripat May 16, 2024 14:25
shtripat
shtripat approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@shtripat shtripat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aead aead merged commit fe54489 into master May 16, 2024
8 checks passed
@aead aead deleted the ls-cmd branch May 16, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shtripat shtripat shtripat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
New CLI
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aead @shtripat