cargo insta test cli: add --disable-nextest-doctest option
#438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilyagr
changed the title
cargo insta test cli: add --disable_nextest_doctest optioncargo insta test cli: add --disable_nextest_doctest option
ilyagr
force-pushed
the
disablenextestdoctest
branch
from
db5982f
to
aa6c979
Compare
ilyagr
changed the title
cargo insta test cli: add --disable_nextest_doctest optioncargo insta test cli: add --disable-nextest-doctest option
ilyagr
force-pushed
the
disablenextestdoctest
branch
2 times, most recently
from
86ab0da
to
66dbc3d
Compare
|
Kinda wish we had a general |
ilyagr
force-pushed
the
disablenextestdoctest
branch
from
66dbc3d
to
96c4d5f
Compare
ilyagr
force-pushed
the
disablenextestdoctest
branch
from
96c4d5f
to
1ea5a03
Compare
This adds an option to `cargo insta test` that prevents running doctests with `cargo test` when Nextest is the test runner, even if the given targets would ortherwise include doctests. I usually use `cargo insta test` with `--test-runner nextest --workspace` options. This always runs `cargo test --doc` after nextest is done, and this takes a bit of time. This is an annoyance for me. I think the project I work on might have a doctest or two, but they are not very relevant, so I'm happy to rely on CI to catch any doctest errors. I only have a vague understanding of `cargo test` options, but I have not found an existing set of test specifiers that's equivalent to `--workspace --no-doctests-pretty-please`.
ilyagr
force-pushed
the
disablenextestdoctest
branch
from
1ea5a03
to
3f88ec3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an option to
cargo insta testthat prevents running doctests withcargo testwhen Nextest is the test runner, even if the given targets would ortherwise include doctests.I usually use
cargo insta testwith--test-runner nextest --workspaceoptions. This always runscargo test --docafter nextest is done and this takes a bit of time. This is an annoyance for me. I think the project I work on might have a doctest or two, but they are not very relevant, so I'm happy to rely on CI to catch any doctest errors.I only have a vague understanding of
cargo testoptions, but I have not found an existing set of test specifiers that's equivalent to--workspace --no-doctests-pretty-please.This is a bit of a quick hack, but I'll be using it, and I think others might appreciate it. If you have any thoughts about a better approach, please let me know.