vendor buildkit v0.9.1-0.20211025222436-33fb83eb7166

[crazy-max]

vendor: github.com/moby/buildkit v0.9.1-0.20211025222436-33fb83eb7166

moby/buildkit@9f254e1...33fb83e

• OpenTracing providers have been replaced with support for OpenTelemetry
  • Add opentelemetry support buildkit#2152
  • vendor: update opentelemetry to 1.0.0-rc buildkit#2192
  • tracing: update to otelhttp roundtripper buildkit#2238
• Outgoing TCP connections are now limited to 4 per registry. Metadata requests get one extra connection not used by layer pulls and pushes.
  • new implementation for limiting tcp connections  buildkit#2259
  • resolver: increase default idle conns reuse buildkit#2242
  • add per domain semaphore to limit concurrent connections buildkit#2247
• Add support for subdirectories when building from Git source
  • git: support subdir component buildkit#2116
• Seccomp profile has been updated to properly handle clone3 syscall support.
  • [v0.9] vendor: update docker to support seccomp clone3 buildkit#2379
• go 1.17
  • update go to 1.17 buildkit#2312
• Support estargz compression type
  • Support estargz compression type buildkit#2246
  • Fix estargz compression loses the original tar metadata buildkit#2352
• Refactor cache metadata interface
  • Refactor cache metadata interface. buildkit#2316
• exporter: support creating blobs with zstd compression
  • exporter: support creating blobs with zstd compression buildkit#2344
• Generate and embed build sources
  • Generate and embed build sources buildkit#2311
• resolver timeout fixes
  • resolver timeout fixes buildkit#2369
• Fix flakiness during import of a cache with empty layers removed
  • Fix flakiness during import of a cache with empty layers removed buildkit#2372
• Move resolver config to a dedicated package
  • Move resolver config to a dedicated package buildkit#2377
• tmpfs size support
  • Add support for shm size buildkit#2384
  • add size to tmpfs mounts buildkit#2411
  • use bytes as given size for tmpfs mount buildkit#2422
• ulimits support
  • Add support for ulimit buildkit#2398
• client: allow setting custom dialer for session endpoint
  • client: allow setting custom dialer for session endpoint buildkit#2419

vendor: go.opentelemetry.io

• go.opentelemetry.io/contrib v0.21.0. Use https://github.com/tonistiigi/opentelemetry-go-contrib.git for now. Waiting for otelhttp: get tracer from current context if not set in constructor open-telemetry/opentelemetry-go-contrib#873
• go.opentelemetry.io/otel v1.0.0-RC1
• go.opentelemetry.io/proto otlp/v0.9.0

Needs to also upgrade the following dependencies:

• google.golang.org/grpc v1.40.0
• google.golang.org/protobuf v1.26.0
• google.golang.org/api v0.25.0
• google.golang.org/genproto v0.0.0-20210602131652-f16073e35f0c
• github.com/golang/protobuf v1.5.2

vendor: github.com/containerd/stargz-snapshotter estargz/v0.8.1-0.20210910092506-a3ecdc9366fb

For estargz compression type

vendor: github.com/containerd/containerd v1.5.1-0.20210721160646-ee27cde735e2

See https://github.com/moby/buildkit/blob/f352ee857b206a3cb81ac7fc88fdef7ae514a911/go.mod#L124

notes

• we could reopen and merge Update fsutil to latest master and remove deprecated fileutil.Matches #42758 after this one
• for containerd I think we could upgrade to the latest 1.6 beta on buildkit repo.
• needs Re-add Finalize method to ImmutableRef. buildkit#2425

---

cc @tonistiigi @thaJeztah @aaronlehmann

Signed-off-by: CrazyMax crazy-max@users.noreply.github.com

[thaJeztah]

Seeing a bunch of these;

Error response from daemon: ENV is not a valid change command
Error response from daemon: ENTRYPOINT is not a valid change command
Error response from daemon: EXPOSE is not a valid change command
Error response from daemon: LABEL is not a valid change command

Also:

=== RUN   TestDockerSuite/TestBuildLineErrorOnBuild
    docker_cli_build_test.go:6074: assertion failed:
        Command:  /usr/local/cli/docker build -t test_build_line_error_onbuild -
        ExitCode: 1
        Error:    exit status 1
        Stdout:   Sending build context to Docker daemon  2.048kB


        Stderr:   Error response from daemon: dockerfile parse error on line 2: ONBUILD requires at least one argument


        Failures:
        Expected stderr to contain "parse error line 2: ONBUILD requires at least one argument"
    --- FAIL: TestDockerSuite/TestBuildLineErrorOnBuild (0.07s)

=== RUN   TestDockerSuite/TestBuildLineErrorUnknownInstruction
    docker_cli_build_test.go:6088: assertion failed:
        Command:  /usr/local/cli/docker build -t test_build_line_error_unknown_instruction -
        ExitCode: 1
        Error:    exit status 1
        Stdout:   Sending build context to Docker daemon  2.048kB


        Stderr:   Error response from daemon: dockerfile parse error on line 3: unknown instruction: NOINSTRUCTION


        Failures:
        Expected stderr to contain "parse error line 3: unknown instruction: NOINSTRUCTION"
    --- FAIL: TestDockerSuite/TestBuildLineErrorUnknownInstruction (0.07s)

=== RUN   TestDockerSuite/TestBuildLineErrorWithComments
    docker_cli_build_test.go:6119: assertion failed:
        Command:  /usr/local/cli/docker build -t test_build_line_error_with_comments -
        ExitCode: 1
        Error:    exit status 1
        Stdout:   Sending build context to Docker daemon  2.048kB


        Stderr:   Error response from daemon: dockerfile parse error on line 5: unknown instruction: NOINSTRUCTION


        Failures:
        Expected stderr to contain "parse error line 5: unknown instruction: NOINSTRUCTION"
    --- FAIL: TestDockerSuite/TestBuildLineErrorWithComments (0.08s)

=== RUN   TestDockerSuite/TestBuildLineErrorWithEmptyLines
    docker_cli_build_test.go:6105: assertion failed:
        Command:  /usr/local/cli/docker build -t test_build_line_error_with_empty_lines -
        ExitCode: 1
        Error:    exit status 1
        Stdout:   Sending build context to Docker daemon  2.048kB


        Stderr:   Error response from daemon: dockerfile parse error on line 6: unknown instruction: NOINSTRUCTION


        Failures:
        Expected stderr to contain "parse error line 6: unknown instruction: NOINSTRUCTION"
    --- FAIL: TestDockerSuite/TestBuildLineErrorWithEmptyLines (0.07s)

Looks like these are because the error output changed (now has on before line 2);

parse error line 2: ONBUILD requires at least one argument
parse error on line 2: ONBUILD requires at least one argument

Perhaps we need to check for line 2: and ONBUILD requires at least one argument, or just check on the last bit only.

Also wondering if that test should be rewritten to use a test-table (feels like they're quite similar), and/or to be an API test, but that's a different topic.

[thaJeztah]

v0.9.1-0 means 0 commits since v0.9.1, correct? In that case, perhaps better to mention it's v0.9.1;

Suggested change

	github.com/moby/buildkit 33fb83eb71666c2b0b5934e3f4e651f8cfa255c4 # master / v0.9.1-0.20211025222436-33fb83eb7166
	github.com/moby/buildkit 33fb83eb71666c2b0b5934e3f4e651f8cfa255c4 # v0.9.1

[crazy-max]

v0.9.1-0 means 0 commits since v0.9.1, correct?

Actually it means it's a base version derived from a semantic version tag that precedes the revision 33fb83eb7166: https://golang.org/ref/mod#pseudo-versions

[thaJeztah]

Ah! 🤦 I looked at it and thought it was from a git describe (which uses -<number of commits>

Should we use tagged versions (or will there be new tags soon?)

[crazy-max]

(or will there be new tags soon?)

Wanted to have the last changes from BuildKit because moby/buildkit#2425 was needed. Next release is v0.9.2 so I think I can open another PR to vendor this release and keep this one as draft for now while waiting for v0.10.0 (cc @tonistiigi).

[crazy-max]

Perhaps we need to check for line 2: and ONBUILD requires at least one argument, or just check on the last bit only.

Thanks for the review, yes indeed I will take a look on failed tests.

[crazy-max]

@thaJeztah

Perhaps we need to check for line 2: and ONBUILD requires at least one argument, or just check on the last bit only.

Related to https://github.com/moby/buildkit/pull/2218/files#diff-ad3df5875e5e135e646046bd3c77fd5f1bb8b2d424d8e97d1ffad6c1c23a4b9aR136. Tests have been updated.

Seeing a bunch of these;

Error response from daemon: ENV is not a valid change command
Error response from daemon: ENTRYPOINT is not a valid change command
Error response from daemon: EXPOSE is not a valid change command
Error response from daemon: LABEL is not a valid change command

Also related to moby/buildkit#2218. Instructions were checked as case-sensitive which is wrong anyway.

[tonistiigi]

@crazy-max As there seem to be swarmkit errors in CI let's make a PR first for containerd-only vendor and see if it has the same issues to understand where the breaking point is.

[thaJeztah]

superseded by #43239