Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove stdout: prefix #2373

Merged
merged 1 commit into from Sep 27, 2017
Merged

Remove stdout: prefix #2373

merged 1 commit into from Sep 27, 2017

Conversation

skeggse
Copy link
Contributor

@skeggse skeggse commented Jul 13, 2016

Fixes #2095, by disabling the stdout: prefix with the browser shim.

Fixes #2095, by disabling the `stdout:` prefix with the browser shim.
@boneskull
Copy link
Member

see dicsussion in #2095. if there's a better alternative than browser-stdout, then I'm open to suggestions

@boneskull boneskull added this to the v4.0.0 milestone Sep 18, 2016
@boneskull boneskull added status: needs review a maintainer should (re-)review this pull request area: browser browser-specific labels Sep 18, 2016
@boneskull
Copy link
Member

@skeggse I realize this was sent over a year ago, but was wondering if you could sign the CLA?

@boneskull boneskull removed this from the v4.0.0 milestone Sep 27, 2017
@skeggse
Copy link
Contributor Author

skeggse commented Sep 27, 2017

Happy to sign the CLA. Unfortunately, it appears to be incomplete. It references a document called [JS Foundation IP Policy]({{ site.url }}{{ site.baseurl }}/pdf/ip-policy.pdf. Please provide a copy of this document, or fix the Licenses section in the CLA itself.

@boneskull
Copy link
Member

boneskull commented Sep 27, 2017

@skeggse you want this URL which is linked in the build section above below. Where did you find that..?

@skeggse
Copy link
Contributor Author

skeggse commented Sep 27, 2017

image

I see this is a standard agreement, you might not have control over the content. Whom should I report this to if you do not have that access?

@boneskull
Copy link
Member

cc @kborchers

@boneskull
Copy link
Member

@skeggse FWIW I found the doc if you want to get it moving. 😉

@skeggse
Copy link
Contributor Author

skeggse commented Sep 27, 2017

@boneskull thank you. I've signed the CLA.

@kborchers
Copy link

@skeggse @boneskull Thanks! We are aware of the broken link and will fix ASAP. The main blocker is that currently, CLA Assistant treats any change to the CLA as a change that invalidates every previous signature. In general, that would be correct behavior to make sure anyone that has signed is made aware of a change and has to sign again to agree to the change. In this case, it's the equivalent of a typo but the application doesn't know the difference so we are trying to formulate a procedure to make the change and migrate all of the signatures over to the "new" version with minimal (preferably no) impact to the projects.

@boneskull
Copy link
Member

@skeggse thanks!

@boneskull boneskull added this to the v4.0.0 milestone Sep 27, 2017
@boneskull boneskull merged commit 37193a4 into mochajs:master Sep 27, 2017
@skeggse skeggse deleted the patch-1 branch September 27, 2017 19:19
@boneskull boneskull removed the status: needs review a maintainer should (re-)review this pull request label Dec 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: browser browser-specific
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Output in Chrome console includes "stdout:"-prefixed lines
3 participants