add --forbid-only and --forbid-pending options #2696

charlierudolph · 2017-01-31T06:10:10Z

resolves #1818

jsf-clabot · 2017-01-31T06:10:12Z

All committers have signed the CLA.

coveralls · 2017-01-31T06:33:35Z

Coverage increased (+0.1%) to 79.234% when pulling ac79018 on charlierudolph:cr-production into 503627c on mochajs:master.

coveralls · 2017-01-31T07:10:48Z

Coverage increased (+0.1%) to 79.234% when pulling 4945fb0 on charlierudolph:cr-production into 503627c on mochajs:master.

Munter · 2017-01-31T13:17:34Z

Looks good to me. I haven't been to involved with this issue, so I'd like a second opinion. Ping @hollomancer @ScottFreeCode @dasilvacontin

coveralls · 2017-01-31T16:28:41Z

Coverage decreased (-7.8%) to 74.287% when pulling 0bf1025 on charlierudolph:cr-production into bc06b85 on mochajs:master.

coveralls · 2017-01-31T16:53:47Z

Coverage increased (+0.1%) to 82.219% when pulling 073b0d9 on charlierudolph:cr-production into bc06b85 on mochajs:master.

ScottFreeCode · 2017-02-01T00:13:05Z

I like the idea in general, and this code (with tests!) looks pretty good. Only thing I wonder about is whether there should be a test case with this.skip in addition to it.skip and it("name" /* and no test function */). However, in the discussion in #1818 and #1935 there was some concern that "production", while less liable to confusion than "strict", doesn't necessarily correlate well to the likely use cases, and there was disagreement as to whether skipped/pending should be included.

I'd like to propose instead having two separate flags named explicitly for what they do: --forbid-only and --forbid-skip/--forbid-pending.

charlierudolph · 2017-02-01T00:15:03Z

Two options are fine by me. I like --forbid-only and --forbid-pending (since skipped tests are marked as pending in that stats)

charlierudolph · 2017-02-01T02:29:38Z

In the next major release, I also think it would be a good idea to make forbid only and forbid pending the default and have the options be --allow-only and --allow-pending

coveralls · 2017-02-01T17:21:50Z

Coverage decreased (-7.8%) to 74.344% when pulling 6780cac on charlierudolph:cr-production into bc06b85 on mochajs:master.

coveralls · 2017-02-01T17:58:50Z

Coverage increased (+0.1%) to 82.251% when pulling e9e56eb on charlierudolph:cr-production into bc06b85 on mochajs:master.

charlierudolph · 2017-02-01T17:59:28Z

@ScottFreeCode this is now updated with the new options

ScottFreeCode

Looks good to me! Thanks for the update.

dasilvacontin · 2017-02-06T10:01:11Z

@charlierudolph: In the next major release, I also think it would be a good idea to make forbid only and forbid pending the default and have the options be --allow-only and --allow-pending

Added only when ENV=production or CI=true, or?

ScottFreeCode · 2017-06-11T20:39:31Z

What about making the test fail as soon as it is marked as pending?

Created #2874 for this.

This Pull Request updates dependency [mocha](https://github.com/mochajs/mocha) from `v3.1.2` to `v3.5.3` <details> <summary>Release Notes</summary> ### [`v3.5.3`](https://github.com/mochajs/mocha/blob/master/CHANGELOG.md#353--2017-09-11) [Compare Source](mochajs/mocha@v3.5.2...v3.5.3) #### 🐛 Fixes - [#3003]: Fix invalid entities in xUnit reporter first appearing in v3.5.1 ([@jkrems]) [#3003]: `mochajs/mocha#3003 --- ### [`v3.5.2`](https://github.com/mochajs/mocha/blob/master/CHANGELOG.md#352--2017-09-10) [Compare Source](mochajs/mocha@v3.5.1...v3.5.2) #### 🐛 Fixes - [#3001]: Fix AMD-related failures first appearing in v3.5.1 ([@boneskull]) [#3001]: `mochajs/mocha#3001 --- ### [`v3.5.1`](https://github.com/mochajs/mocha/blob/master/CHANGELOG.md#351--2017-09-09) [Compare Source](mochajs/mocha@v3.5.0...v3.5.1) #### 📰 News - 📣 Mocha is now sponsoring [PDXNode](http://pdxnode.org)! If you're in the [Portland](https://wikipedia.org/wiki/Portland,_Oregon) area, come check out the monthly talks and hack nights! #### 🐛 Fixes - [#2997]: Fix missing `xit` export for "require" interface ([@solodynamo]) - [#2957]: Fix unicode character handling in XUnit reporter failures ([@jkrems]) #### 🔩 Other - [#2986]: Add issue and PR templates ([@kungapal]) - [#2918]: Drop bash dependency for glob-related tests ([@ScottFreeCode]) - [#2922]: Improve `--compilers` coverage ([@ScottFreeCode]) - [#2981]: Fix tpyos and spelling errors ([@jsoref]) [#2997]: `mochajs/mocha#2997 [#2957]: `mochajs/mocha#2957 [#2918]: `mochajs/mocha#2918 [#2986]: `mochajs/mocha#2986 [#2922]: `mochajs/mocha#2922 [#2981]: `mochajs/mocha#2981 [@solodynamo]: https://github.com/solodynamo [@jkrems]: https://github.com/jkrems [@jsoref]: https://github.com/jsoref --- ### [`v3.5.0`](https://github.com/mochajs/mocha/blob/master/CHANGELOG.md#350--2017-07-31) [Compare Source](mochajs/mocha@v3.4.2...v3.5.0) #### 📰 News - Mocha now has a [code of conduct](https://github.com/mochajs/mocha/blob/master/.github/CODE_OF_CONDUCT.md) (thanks [@kungapal]!). - Old issues and PRs are now being marked "stale" by [Probot's "Stale" plugin](https://github.com/probot/stale). If an issue is marked as such, and you would like to see it remain open, simply add a new comment to the ticket or PR. - **WARNING**: Support for non-ES5-compliant environments will be dropped starting with version 4.0.0 of Mocha! #### 🔒 Security Fixes - [#2860]: Address [CVE-2015-8315](https://nodesecurity.io/advisories/46) via upgrade of [debug](https://npm.im/debug) ([@boneskull]) #### 🎉 Enhancements - [#2696]: Add `--forbid-only` and `--forbid-pending` flags. Use these in CI or hooks to ensure tests aren't accidentally being skipped! ([@charlierudolph]) - [#2813]: Support Node.js 8's `--napi-modules` flag ([@jupp0r]) #### 🔩 Other - Various CI-and-test-related fixes and improvements ([@boneskull], [@dasilvacontin], [@PopradiArpad], [@Munter], [@ScottFreeCode]) - "Officially" support Node.js 8 ([@elergy]) [#2860]: `mochajs/mocha#2860 [#2696]: `mochajs/mocha#2696 [#2813]: `mochajs/mocha#2813 [@charlierudolph]: https://github.com/charlierudolph [@PopradiArpad]: https://github.com/PopradiArpad [@kungapal]: https://github.com/kungapal [@elergy]: https://github.com/elergy [@jupp0r]: https://github.com/jupp0r --- ### [`v3.4.2`](https://github.com/mochajs/mocha/blob/master/CHANGELOG.md#342--2017-05-24) [Compare Source](mochajs/mocha@v3.4.1...v3.4.2) #### 🐛 Fixes - [#2802]: Remove call to deprecated `os.tmpDir` ([@makepanic]) - [#2820]: Eagerly set `process.exitCode` ([@chrisleck]) #### 🔩 Other - [#2778]: Move linting into an npm script ([@Munter]) [@chrisleck]: https://github.com/chrisleck [@makepanic]: https://github.com/makepanic [@Munter]: https://github.com/Munter [#2778]: `mochajs/mocha#2778 [#2802]: `mochajs/mocha#2802 [#2820]: `mochajs/mocha#2820 --- ### [`v3.4.1`](https://github.com/mochajs/mocha/blob/master/CHANGELOG.md#341--2017-05-14) [Compare Source](mochajs/mocha@v3.3.0...v3.4.1) Fixed a publishing mishap with git's autocrlf settings. --- ### [`v3.3.0`](https://github.com/mochajs/mocha/blob/master/CHANGELOG.md#330--2017-04-24) [Compare Source](mochajs/mocha@v3.2.0...v3.3.0) Thanks to all our contributors, maintainers, sponsors, and users! ❤️ As highlights: - We've got coverage now! - Testing is looking less flaky \o/. - No more nitpicking about "mocha.js" build on PRs. #### 🎉 Enhancements - [#2659]: Adds support for loading reporter from an absolute or relative path ([@sul4bh]) - [#2769]: Support `--inspect-brk` on command-line ([@igwejk]) #### 🐛 Fixes - [#2662]: Replace unicode chars w/ hex codes in HTML reporter ([@rotemdan]) #### 🔍 Coverage - [#2672]: Add coverage for node tests ([@c089], [@Munter]) - [#2680]: Increase tests coverage for base reporter ([@epallerols]) - [#2690]: Increase tests coverage for doc reporter ([@craigtaub]) - [#2701]: Increase tests coverage for landing, min, tap and list reporters ([@craigtaub]) - [#2691]: Increase tests coverage for spec + dot reporters ([@craigtaub]) - [#2698]: Increase tests coverage for xunit reporter ([@craigtaub]) - [#2699]: Increase tests coverage for json-stream, markdown and progress reporters ([@craigtaub]) - [#2703]: Cover .some() function in utils.js with tests ([@seppevs]) - [#2773]: Add tests for loading reporters w/ relative/absolute paths ([@sul4bh]) #### 🔩 Other - Remove bin/.eslintrc; ensure execs are linted ([@boneskull]) - [#2542]: Expand CONTRIBUTING.md ([@boneskull]) - [#2660]: Double timeouts on integration tests ([@Munter]) - [#2653]: Update copyright year ([@Scottkao85], [@Munter]) - [#2621]: Update dependencies to enable Greenkeeper ([@boneskull], [@greenkeeper]) - [#2625]: Use trusty container in travis-ci; use "artifacts" addon ([@boneskull]) - [#2670]: doc(CONTRIBUTING): fix link to org members ([@coderbyheart]) - Add Mocha propaganda to README.md ([@boneskull]) - [#2470]: Avoid test flake in "delay" test ([@boneskull]) - [#2675]: Limit browser concurrency on sauce ([@boneskull]) - [#2669]: Use temporary test-only build of mocha.js for browsers tests ([@Munter]) - Fix "projects" link in README.md ([@boneskull]) - [#2678]: Chore(Saucelabs): test on IE9, IE10 and IE11 ([@coderbyheart]) - [#2648]: Use `semistandard` directly ([@kt3k]) - [#2727]: Make the build reproducible ([@lamby]) [@boneskull]: https://github.com/boneskull [@c089]: https://github.com/c089 [@coderbyheart]: https://github.com/coderbyheart [@craigtaub]: https://github.com/craigtaub [@epallerols]: https://github.com/epallerols [@greenkeeper]: https://github.com/greenkeeper [@igwejk]: https://github.com/igwejk [@kt3k]: https://github.com/kt3k [@lamby]: https://github.com/lamby [@Munter]: https://github.com/Munter [@rotemdan]: https://github.com/rotemdan [@seppevs]: https://github.com/seppevs [@sul4bh]: https://github.com/sul4bh [#2470]: `mochajs/mocha#2470 [#2542]: `mochajs/mocha#2542 [#2621]: `mochajs/mocha#2621 [#2625]: `mochajs/mocha#2625 [#2648]: `mochajs/mocha#2648 [#2653]: `mochajs/mocha#2653 [#2659]: `mochajs/mocha#2659 [#2660]: `mochajs/mocha#2660 [#2662]: `mochajs/mocha#2662 [#2669]: `mochajs/mocha#2669 [#2670]: `mochajs/mocha#2670 [#2672]: `mochajs/mocha#2672 [#2675]: `mochajs/mocha#2675 [#2678]: `mochajs/mocha#2678 [#2680]: `mochajs/mocha#2680 [#2690]: `mochajs/mocha#2690 [#2691]: `mochajs/mocha#2691 [#2698]: `mochajs/mocha#2698 [#2699]: `mochajs/mocha#2699 [#2701]: `mochajs/mocha#2701 [#2703]: `mochajs/mocha#2703 [#2727]: `mochajs/mocha#2727 [#2769]: `mochajs/mocha#2769 [#2773]: `mochajs/mocha#2773 --- ### [`v3.2.0`](https://github.com/mochajs/mocha/blob/master/CHANGELOG.md#320--2016-11-24) [Compare Source](mochajs/mocha@v3.1.2...v3.2.0) #### 📰 News ##### Mocha is now a JS Foundation Project! Mocha is proud to have joined the [JS Foundation](https://js.foundation). For more information, [read the announcement](https://js.foundation/announcements/2016/10/17/Linux-Foundation-Unites-JavaScript-Community-Open-Web-Development/). ##### Contributor License Agreement Under the foundation, all contributors to Mocha must sign the [JS Foundation CLA](https://js.foundation/CLA/) before their code can be merged. When sending a PR--if you have not already signed the CLA--a friendly bot will ask you to do so. Mocha remains licensed under the [MIT license](https://github.com/mochajs/mocha/blob/master/LICENSE). #### 🐛 Bug Fix - [#2535]: Fix crash when `--watch` encounters broken symlinks ([@villesau]) - [#2593]: Fix (old) regression; incorrect symbol shown in `list` reporter ([@Aldaviva]) - [#2584]: Fix potential error when running XUnit reporter ([@vobujs]) #### 🎉 Enhancement - [#2294]: Improve timeout error messaging ([@jeversmann], [@boneskull]) - [#2520]: Add info about `--inspect` flag to CLI help ([@ughitsaaron]) #### 🔩 Other - [#2570]: Use [karma-mocha](https://npmjs.com/package/karma-mocha) proper ([@boneskull]) - Licenses updated to reflect new copyright, add link to license and browser matrix to `README.md` ([@boneskull], [@ScottFreeCode], [@dasilvacontin]) [#2294]: `mochajs/mocha#2294 [#2535]: `mochajs/mocha#2535 [#2520]: `mochajs/mocha#2520 [#2593]: `mochajs/mocha#2593 [#2584]: `mochajs/mocha#2584 [#2570]: `mochajs/mocha#2570 [@Aldaviva]: https://github.com/Aldaviva [@jeversmann]: https://github.com/jeversmann [@ughitsaaron]: https://github.com/ughitsaaron [@villesau]: https://github.com/villesau [@vobujs]: https://github.com/vobujs Thanks to all our contributors, sponsors and backers! Keep on the lookout for a public roadmap and new contribution guide coming soon. --- </details> --- This PR has been generated by [Renovate Bot](https://renovatebot.com).

* add --production option * update comment * fix lint * add tests * remove only * update * simplify * remove onlys * fix and * update self.failures * update test description * Remove breaking semicolon * fix lint

add --production option

03ea260

charlierudolph added 2 commits January 30, 2017 22:14

update comment

ac79018

fix lint

4945fb0

Munter self-requested a review January 31, 2017 13:18

Munter approved these changes Jan 31, 2017

View reviewed changes

charlierudolph added 2 commits January 31, 2017 08:10

add tests

7d6962d

Merge branch 'master' into cr-production

0bf1025

remove only

073b0d9

update

c2a84e6

charlierudolph changed the title ~~add --production option~~ add --forbid-only and --forbid-pending options Feb 1, 2017

charlierudolph added 2 commits February 1, 2017 09:16

simplify

6780cac

remove onlys

6d0ce83

fix and

e9e56eb

ScottFreeCode approved these changes Feb 6, 2017

View reviewed changes

Munter added semver-minor implementation requires increase of "minor" version number; "features" to-merge type: feature enhancement proposal labels Feb 6, 2017

ScottFreeCode mentioned this pull request Jun 11, 2017

Print failures for pending/only forbidden #2874

Merged

ScottFreeCode mentioned this pull request Jun 26, 2017

upgrade to debug@2.6.8; closes #2859 #2860

Merged

boneskull removed status: needs review a maintainer should (re-)review this pull request status: waiting for author waiting on response from OP - more information needed labels Dec 12, 2017

irfancharania mentioned this pull request Sep 21, 2018

Add --forbid-only and --forbid-pending options cypress-io/cypress#2503

Closed

renovate bot mentioned this pull request Oct 4, 2018

Update dependency mocha to v5 - autoclosed scidock/koa-prerender#5

Closed

1 task

renovate bot mentioned this pull request Oct 22, 2018

Update dependency mocha to v3.5.3 - autoclosed googleapis/nodejs-datastore-session#17

Closed

renovate bot mentioned this pull request Nov 1, 2018

Update dependency mocha to v5 justinbarry/augur-copy#93

Merged

renovate bot mentioned this pull request Nov 14, 2018

Update dependency mocha to v5 hairyhenderson/nursery_alert#17

Merged

renovate bot mentioned this pull request Nov 23, 2018

chore(deps): update dependency mocha to v5 JLHwung/tianzige#37

Merged

This was referenced Dec 23, 2018

Update dependency mocha to v5 - autoclosed mateodelnorte/microsvc-slave#7

Closed

chore(deps): update dependency mocha to v5 status-board/status-board-cli#175

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add --forbid-only and --forbid-pending options #2696

add --forbid-only and --forbid-pending options #2696

charlierudolph commented Jan 31, 2017

jsf-clabot commented Jan 31, 2017 •

edited

coveralls commented Jan 31, 2017

coveralls commented Jan 31, 2017

Munter commented Jan 31, 2017

coveralls commented Jan 31, 2017

coveralls commented Jan 31, 2017

ScottFreeCode commented Feb 1, 2017

charlierudolph commented Feb 1, 2017

charlierudolph commented Feb 1, 2017

coveralls commented Feb 1, 2017

coveralls commented Feb 1, 2017

charlierudolph commented Feb 1, 2017

ScottFreeCode left a comment

dasilvacontin commented Feb 6, 2017 •

edited

ScottFreeCode commented Jun 11, 2017

add --forbid-only and --forbid-pending options #2696

add --forbid-only and --forbid-pending options #2696

Conversation

charlierudolph commented Jan 31, 2017

jsf-clabot commented Jan 31, 2017 • edited

coveralls commented Jan 31, 2017

coveralls commented Jan 31, 2017

Munter commented Jan 31, 2017

coveralls commented Jan 31, 2017

coveralls commented Jan 31, 2017

ScottFreeCode commented Feb 1, 2017

charlierudolph commented Feb 1, 2017

charlierudolph commented Feb 1, 2017

coveralls commented Feb 1, 2017

coveralls commented Feb 1, 2017

charlierudolph commented Feb 1, 2017

ScottFreeCode left a comment

Choose a reason for hiding this comment

dasilvacontin commented Feb 6, 2017 • edited

ScottFreeCode commented Jun 11, 2017

jsf-clabot commented Jan 31, 2017 •

edited

dasilvacontin commented Feb 6, 2017 •

edited