New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add --forbid-only and --forbid-pending options #2696
Changes from 10 commits
03ea260
ac79018
4945fb0
7d6962d
0bf1025
073b0d9
c2a84e6
6780cac
6d0ce83
e9e56eb
5c201e2
f7852da
164934a
6ad192b
43ce4d7
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
describe('forbid only - test marked with only', function () { | ||
it('test1', function () {}); | ||
it.only('test2', function () {}); | ||
it('test3', function () {}); | ||
}); |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
describe('forbid only - all test pass', function () { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. test -> tests There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I feel like There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. fixed |
||
it('test1', function () {}); | ||
it('test2', function () {}); | ||
it('test3', function () {}); | ||
}); |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
describe('forbid pending - all test pass', function () { | ||
it('test1', function () {}); | ||
it('test2', function () {}); | ||
it('test3', function () {}); | ||
}); |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
describe('forbid pending - test without function', function () { | ||
it('test1', function () {}); | ||
it('test2'); | ||
it('test3', function () {}); | ||
}); |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
describe('forbid pending - test marked with skip', function () { | ||
it('test1', function () {}); | ||
it.skip('test2', function () {}); | ||
it('test3', function () {}); | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like updating
self.failures
to its new value before callingfn
would be good for consistency.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed