Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated data to IANA TZDB 2018d #596

Merged
merged 2 commits into from Apr 17, 2018
Merged

Conversation

ellenaua
Copy link
Contributor

@ellenaua ellenaua commented Apr 13, 2018

  • Updated data to IANA TZDB 2018d
  • Fixed 3 failing tests by introducing "expect" in makeTestGuess settings:
"guess" : helpers.makeTestGuess("America/Cancun", 
     { offset: false, abbr: true, expect: "America/Panama" }),
"guess" : helpers.makeTestGuess("America/Fort_Nelson", 
    { offset: true, abbr: true, expect: "America/Phoenix" }),
"guess" : helpers.makeTestGuess("America/Metlakatla", 
   { offset: true, abbr: true, expect: "America/Anchorage" }),

here it means that tz.guess() is expected to return "America/Panama" when timezone is set to "America/Cancun"

@jsf-clabot
Copy link

jsf-clabot commented Apr 13, 2018

CLA assistant check
All committers have signed the CLA.

@mattjohnsonpint
Copy link
Contributor

LGTM. Thanks!

@ellenaua ellenaua merged commit f1af64c into moment:develop Apr 17, 2018
@ellenaua ellenaua deleted the iana2018d branch April 17, 2018 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants