Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLOUDP-238518: Windows binaries are not signed #2781

Merged
merged 1 commit into from Mar 19, 2024
Merged

CLOUDP-238518: Windows binaries are not signed #2781

merged 1 commit into from Mar 19, 2024

Conversation

fmenezes
Copy link
Collaborator

@fmenezes fmenezes commented Mar 19, 2024 •
edited

Proposed changes

Windows binaries are not signed

Jira ticket: CLOUDP-238518

Closes #[issue number]

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation in document requirements section listed in CONTRIBUTING.md (if appropriate)
  • I have addressed the @mongodb/docs-cloud-team comments (if appropriate)
  • I have updated test/README.md (if an e2e test has been added)
  • I have run make fmt and formatted my code

Further comments

fmenezes
fmenezes commented Mar 19, 2024
View reviewed changes
build/package/windows_notarize.sh
@@ -16,7 +16,7 @@

set -Eeou pipefail

EXE_FILE="dist/windows_windows_amd64_v1/bin/atlas.exe"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

main fix

@fmenezes fmenezes mentioned this pull request Mar 19, 2024
Merged
6 tasks
@fmenezes fmenezes marked this pull request as ready for review March 19, 2024 13:03
@fmenezes fmenezes requested a review from a team as a code owner March 19, 2024 13:03
@fmenezes fmenezes merged commit 861bd1b into master Mar 19, 2024
20 checks passed
@fmenezes fmenezes deleted the CLOUDP-238518 branch March 19, 2024 14:54
@fmenezes fmenezes mentioned this pull request Apr 5, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gssbzn gssbzn gssbzn approved these changes

@andreaangiolillo andreaangiolillo andreaangiolillo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fmenezes @gssbzn @andreaangiolillo