Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLOUDP-238518: Windows binaries are not signed #2781

Merged
merged 1 commit into from Mar 19, 2024
Merged

CLOUDP-238518: Windows binaries are not signed #2781

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion build/ci/release.yml
View file
Open in desktop
Expand Up @@ -264,10 +264,11 @@ tasks:
local_files_include_filter:
- src/github.com/mongodb/mongodb-atlas-cli/bin/*.exe
- src/github.com/mongodb/mongodb-atlas-cli/dist/*.msi
remote_file: ${project}/dist/${revision}_${created_at}/
remote_file: ${project}/dist/${revision}_${created_at}/unsigned_
bucket: mongodb-mongocli-build
permissions: public-read
content_type: ${content_type|application/octet-stream}
display_name: unsigned
- name: package_goreleaser
tags: ["packaging"]
depends_on:
Expand Down
11 changes: 7 additions & 4 deletions build/package/download-win-binaries.sh
View file
Open in desktop
Expand Up @@ -28,10 +28,13 @@ fi
PACKAGE_NAME="mongodb-atlas-cli_${VERSION_NAME}_windows_x86_64.msi"
BINARY_NAME="atlas.exe"

PACKAGE_URL=https://${BUCKET}.s3.amazonaws.com/${project}/dist/${revision}_${created_at}/unsigned_${PACKAGE_NAME}
BINARY_URL=https://${BUCKET}.s3.amazonaws.com/${project}/dist/${revision}_${created_at}/unsigned_${BINARY_NAME}

pushd bin

echo "downloading https://${BUCKET}.s3.amazonaws.com/${project}/dist/${revision}_${created_at}/${PACKAGE_NAME} into $PWD"
curl "https://${BUCKET}.s3.amazonaws.com/${project}/dist/${revision}_${created_at}/${PACKAGE_NAME}" --output "${PACKAGE_NAME}"
echo "downloading $PACKAGE_URL into $PWD/$PACKAGE_NAME"
curl "$PACKAGE_URL" --output "${PACKAGE_NAME}"

echo "downloading https://${BUCKET}.s3.amazonaws.com/${project}/dist/${revision}_${created_at}/${BINARY_NAME} into $PWD"
curl "https://${BUCKET}.s3.amazonaws.com/${project}/dist/${revision}_${created_at}/${BINARY_NAME}" --output "${BINARY_NAME}"
echo "downloading $BINARY_URL into $PWD/$BINARY_NAME"
curl "$BINARY_URL" --output "${BINARY_NAME}"
2 changes: 1 addition & 1 deletion build/package/windows_notarize.sh
View file
Open in desktop
Expand Up @@ -16,7 +16,7 @@

set -Eeou pipefail

EXE_FILE="dist/windows_windows_amd64_v1/bin/atlas.exe"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

main fix

EXE_FILE="bin/atlas.exe"
MSI_FILE="bin/mongodb-atlas-cli_${VERSION}_windows_x86_64.msi"

if [[ -f "$EXE_FILE" && -f "$MSI_FILE" ]]; then
Expand Down