CLOUDP-237254: Set deploymet_type telemetry value in missing atlas deployments commands

[blva]

Proposed changes

Jira ticket: CLOUDP-237254

We were sending telemetry events on selection and some commands, this is an approach to try to unify and append deployment_type value at 3 steps:

1. pre-run (this covers if customer provides a flag but fails the command)
2. on selection (this covers if customer goes through interactive flow but fails the command)
3. post-run (this covers all cases where the command is successful)

I'll add a follow-up PR adding the telemetry to all commands, but want to get a review on this approach first.

Checklist

• I have signed the MongoDB CLA
• I have added tests that prove my fix is effective or that my feature works
• I have added any necessary documentation in document requirements section listed in CONTRIBUTING.md (if appropriate)
• I have addressed the @mongodb/docs-cloud-team comments (if appropriate)
• I have updated test/README.md (if an e2e test has been added)
• I have run make fmt and formatted my code

Further comments

[fmenezes]

what is the expectation for list here?

[blva]

it will only set it if customer provides --type local/atlas, otherwise it will not set the type

[gssbzn]

[nit] in go the recommendation is to accept interfaces and return structs, not the other way around

[blva]

we can do that it may look a bit weird for DeploymentOpts though as there we need to use DeploymentType we'd need to cast with something like this (which works fine):

func NewDeploymentTypeTelemetry(opts DeploymentTelemetry) *DeploymentOpts {
	return opts.(*DeploymentOpts)
}

[gssbzn]

it's a bit weird that you need to cast it to an interface if it accepts an interface but let's leave this for now

[gssbzn]

I think the problem may be this is not really a "new" which should return a new object but this is more of a "cast as interface" thing

[gssbzn]

do the thing once

Suggested change

	if opts.IsLocalDeploymentType() {
	telemetry.AppendOption(telemetry.WithDeploymentType(LocalCluster))
	} else if opts.IsAtlasDeploymentType() {
	telemetry.AppendOption(telemetry.WithDeploymentType(AtlasCluster))
	}
	var deploymentType string
	if opts.IsLocalDeploymentType() {
	deploymentType = LocalCluster
	} else if opts.IsAtlasDeploymentType() {
	deploymentType = AtlasCluster
	}
	if deploymentType != "" {
	telemetry.AppendOption(telemetry.WithDeploymentType())
	}

I would also say maybe is better to do a switch over opts.DeploymentType

[blva]

i prefer the suggestion you gave above as it uses the standard methods to check if it's atlas or local

[gssbzn]

LGTM