New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLOUDP-237254: Set deploymet_type telemetry value in missing atlas deployments commands #2790
Changes from all commits
23dfb25
7095e5a
a40caeb
00bb2dd
f69e7fd
268e14d
1b8d5e2
417c105
2fb0acc
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
// Copyright 2023 MongoDB Inc | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
package options | ||
|
||
import ( | ||
"github.com/mongodb/mongodb-atlas-cli/atlascli/internal/telemetry" | ||
) | ||
|
||
//go:generate mockgen -destination=../../../../mocks/mock_deployment_opts_telemetry.go -package=mocks github.com/mongodb/mongodb-atlas-cli/atlascli/internal/cli/atlas/deployments/options DeploymentTelemetry | ||
type DeploymentTelemetry interface { | ||
AppendDeploymentType() | ||
} | ||
|
||
func NewDeploymentTypeTelemetry(opts *DeploymentOpts) DeploymentTelemetry { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [nit] in go the recommendation is to accept interfaces and return structs, not the other way around There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. we can do that it may look a bit weird for func NewDeploymentTypeTelemetry(opts DeploymentTelemetry) *DeploymentOpts {
return opts.(*DeploymentOpts)
} There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. it's a bit weird that you need to cast it to an interface if it accepts an interface but let's leave this for now There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think the problem may be this is not really a "new" which should return a new object but this is more of a "cast as interface" thing |
||
return opts | ||
} | ||
|
||
func (opts *DeploymentOpts) AppendDeploymentType() { | ||
var deploymentType string | ||
if opts.IsLocalDeploymentType() { | ||
deploymentType = LocalCluster | ||
} else if opts.IsAtlasDeploymentType() { | ||
deploymentType = AtlasCluster | ||
} | ||
if deploymentType != "" { | ||
telemetry.AppendOption(telemetry.WithDeploymentType(deploymentType)) | ||
} | ||
} |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is the expectation for list here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it will only set it if customer provides --type local/atlas, otherwise it will not set the type