HELP-56667: Revert changes in PR #1967 for DiskIOPS for Kubernetes deployment #2812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helderjs
previously approved these changes
Mar 27, 2024
s-urbaniak
previously approved these changes
Mar 28, 2024
gssbzn
reviewed
Mar 28, 2024
internal/pointer/pointer.go
Outdated
| @@ -44,3 +44,11 @@ func GetNonZeroValue[T constraints.Integer](val T) *T { | |||
|
|
|||
| return nil | |||
| } | |||
|
|
|||
| func IntToInt64(source *int) *int64 { | |||
There was a problem hiding this comment.
can you move this closer to the kube package, these methods are a bit of a hack for converting between the SDK and the operator internal and not really helpful for them to be exposed to all the code base
There was a problem hiding this comment.
Fixed. Moved to .../kubernetes/operator/convert/ package
igor-karpukhin
dismissed stale reviews from s-urbaniak and helderjs
via
5845fb4
igor-karpukhin
force-pushed
the
HELP-56667-disk-iops
branch
from
5845fb4
to
4ef85a5
Compare
igor-karpukhin
force-pushed
the
HELP-56667-disk-iops
branch
from
4ef85a5
to
1f67c53
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Jira ticket: HELP-56667
Closes #[issue number]
Checklist
make fmtand formatted my codeFurther comments