New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: added additional tests #12
Conversation
@@ -559,6 +559,230 @@ func Test_MergeResponses(t *testing.T) { | |||
} | |||
} | |||
|
|||
func Test_MergeSchemas(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
func Test_MergeSchemas(t *testing.T) { | |
func TestOasDiff_mergeSchemas(t *testing.T) { |
err := o.mergeSchemas() | ||
if err != nil && !tc.error { | ||
t.Errorf("No error expected but got the error %v", err) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
err := o.mergeSchemas() | |
if err != nil && !tc.error { | |
t.Errorf("No error expected but got the error %v", err) | |
} | |
tc.wantErr(o.mergeSchemas()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the above may produce lint warnings/unexpected test results do to parallel and need some clousure with tc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
Proposed changes
Checklist
Further comments