Skip to content
This repository has been archived by the owner on Apr 27, 2023. It is now read-only.

Add the missing data review request info #533

Merged
merged 1 commit into from Apr 9, 2021

Conversation

Dexterp37
Copy link
Contributor

I forgot to update #505 with this link :-D

This additionally removes the bogus 'onboarding' ping.

Checklist for reviewer:

  • The description should reference a bug or github issue, if relevant.
  • There must be a CHANGELOG.md entry for any non-test change.
  • Any change to the NPM commands must be carefully reviewed to make sure it won't break the Add-ons pipeline.
  • Any version increase must follow the release process.

This additionally removes the bogus 'onboarding' ping.
@Dexterp37 Dexterp37 requested a review from rhelmer April 8, 2021 17:35
@Dexterp37 Dexterp37 self-assigned this Apr 8, 2021
@rhelmer
Copy link
Contributor

rhelmer commented Apr 9, 2021

I forgot to update #505 with this link :-D

This additionally removes the bogus 'onboarding' ping.

Checklist for reviewer:

* [ ]  The description should reference a bug or github issue, if relevant.

* [ ]  There must be a [`CHANGELOG.md`](./CHANGELOG.md) entry for any non-test change.

Should we change this to be "any non-docs or non-test change"?

@Dexterp37
Copy link
Contributor Author

I forgot to update #505 with this link :-D
This additionally removes the bogus 'onboarding' ping.
Checklist for reviewer:

* [ ]  The description should reference a bug or github issue, if relevant.

* [ ]  There must be a [`CHANGELOG.md`](./CHANGELOG.md) entry for any non-test change.

Should we change this to be "any non-docs or non-test change"?

Oh, yeah, good idea!

@Dexterp37 Dexterp37 merged commit 4818149 into mozilla-rally:master Apr 9, 2021
@Dexterp37 Dexterp37 deleted the data_review_fixup branch April 9, 2021 16:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants