Skip to content
This repository has been archived by the owner on Apr 27, 2023. It is now read-only.

Add the missing data review request info #533

Merged
merged 1 commit into from
Apr 9, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
13 changes: 1 addition & 12 deletions docs/metrics.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ This means you might have to go searching through the dependency tree to get a f
# Pings

- [deletion-request](#deletion-request)
- [onboarding](#onboarding)

## deletion-request

Expand All @@ -23,17 +22,7 @@ In addition to those built-in metrics, the following metrics are added to the pi

| Name | Type | Description | Data reviews | Extras | Expiration | [Data Sensitivity](https://wiki.mozilla.org/Firefox/Data_Collection) |
| --- | --- | --- | --- | --- | --- | --- |
| rally.id |[uuid](https://mozilla.github.io/glean/book/user/metrics/uuid.html) |The id of the Rally client. |[Review 1](TODO)||never | |

## onboarding

All Glean pings contain built-in metrics in the [`ping_info`](https://mozilla.github.io/glean/book/user/pings/index.html#the-ping_info-section) and [`client_info`](https://mozilla.github.io/glean/book/user/pings/index.html#the-client_info-section) sections.

In addition to those built-in metrics, the following metrics are added to the ping:

| Name | Type | Description | Data reviews | Extras | Expiration | [Data Sensitivity](https://wiki.mozilla.org/Firefox/Data_Collection) |
| --- | --- | --- | --- | --- | --- | --- |
| rally.id |[uuid](https://mozilla.github.io/glean/book/user/metrics/uuid.html) |The id of the Rally client. |[Review 1](TODO)||never | |
| rally.id |[uuid](https://mozilla.github.io/glean/book/user/metrics/uuid.html) |The id of the Rally client. |[mozilla-rally/rally-core-addon#505](https://github.com/mozilla-rally/rally-core-addon/pull/505#issuecomment-815826426)||never | |

Data categories are [defined here](https://wiki.mozilla.org/Firefox/Data_Collection).

Expand Down
3 changes: 1 addition & 2 deletions metrics.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,12 @@ rally:
lifetime: user
send_in_pings:
- deletion-request
- onboarding
description: |
The id of the Rally client.
bugs:
- https://github.com/mozilla-rally/rally-core-addon/issues/117
data_reviews:
- TODO
- https://github.com/mozilla-rally/rally-core-addon/pull/505#issuecomment-815826426
notification_emails:
- than@mozilla.com
expires: never